Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhpWord/Element/AbstractElement, setNewStyle could be static, or better deprecated #557

Closed
RKaczmarek opened this issue Jun 16, 2015 · 0 comments
Closed

PhpWord/Element/AbstractElement, setNewStyle could be static, or better deprecated #557

RKaczmarek opened this issue Jun 16, 2015 · 0 comments

Comments

@RKaczmarek
Copy link

RKaczmarek commented Jun 16, 2015 •
edited by Progi1984

The method setNewStyle is not dependent on any instance variable and could be static.

I would like to discuss how usefull this method is. In my opinion, it is not useful to use it, because there is no check of style type, which makes it unstable to use in subclasses.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RKaczmarek