Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate style collection for multiple phpword instances #551

Closed
RKaczmarek opened this issue Jun 10, 2015 · 0 comments
Closed

Seperate style collection for multiple phpword instances #551

RKaczmarek opened this issue Jun 10, 2015 · 0 comments

Comments

@RKaczmarek
Copy link

RKaczmarek commented Jun 10, 2015

Hi,
i had a look at the style collection and it seems like there is only one static collection pool for all stored styles. And the add{element}Style method does not override the value, it rejects after first addition.

That could cause the following prolems:

  • two or more instances of phpword in one script could try to add a font style with the same name.
  • one of the instances could use a wrong style without even knowing about it

Maybe it would be better if phpword instances use an instance of Style to have it's own style collection pool?


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant