Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared with PHPOffice #485

Closed
Progi1984 opened this issue Mar 4, 2015 · 8 comments
Closed

Shared with PHPOffice #485

Progi1984 opened this issue Mar 4, 2015 · 8 comments
Assignees
Milestone

Comments

@Progi1984
Copy link
Member

Some parts of PHPOffice projects are recurrents :

The idea would be to create a package (PHPOfficeShared or PHPOffice or...) which permits to group useful functions in one place for improving all projects.

Poke teams :

  • @PHPOffice/phpexcel-team
  • @PHPOffice/phppowerpoint-team
  • @PHPOffice/phpword-team
@MarkBaker
Copy link
Member

Would also apply to components like the OLE Reader/Writer, and also to some document-level elements like DocumentProperties and parts of DocumentSecurity

@MarkBaker
Copy link
Member

Useful in a separate repository when dependencies can be managed via composer, but harder for doing a non-composer build of all components

@Progi1984
Copy link
Member Author

@MarkBaker Exactly for OLE and DocumentProperties.

Ah ! Composer save our lives :p
May be the solution will be an autoload (not in the case where we use Composer) for loading PHPExcel & PhpOfficeShared ?

@MarkBaker
Copy link
Member

Namespacing would be a godsend there, but that requires forcing the minimum version requirement to PHP 5.3.0.... which is all to the good as well, as it means guaranteed SPL in PHP core, closures, etc

@Progi1984
Copy link
Member Author

@MarkBaker Actually, the minimal support is :

  • 5.2.0 for PHPExcel
  • 5.3.0 for PHPPowerPoint
  • 5.3.3 for PHPWord

@ghost
Copy link

ghost commented Mar 5, 2015

+1 for separate subproject in PHPOffice family managed by Composer. So we can have other projects depended on it. I would call it Common (\PhpOffice\Common). Shared is not a good name, because this term is used in OOXML (there are so called shared objects). So, to avoid confusion, we should choose a different name.

As regards PHP version, I suggest starting with at least 5.3. PHPExcel will use the lib when got PHP upgraded.

@Progi1984
Copy link
Member Author

@RomanSyroeshko Good idea for Common ;)
I agree with you for PHPExcel.

@Progi1984
Copy link
Member Author

@Progi1984 Progi1984 self-assigned this Jun 24, 2015
@Progi1984 Progi1984 added this to the 0.13.0 milestone Jun 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants