Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: documentation about paragraph indentation #1764

Merged
merged 1 commit into from
Dec 8, 2019

Conversation

mdupont
Copy link
Contributor

@mdupont mdupont commented Nov 28, 2019

Description

As stated in #358, the documentation about indent and hanging styling for the Paragraph element is wrong:

  • It states that the values for indent and hanging are in twips while they are in half-inches
  • It does not mention the indentation property which allows setting values in twips and the firstLine and right indentations as well.

Fixes #358

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report) Documentation change only, no new code
  • I have updated the documentation to describe the changes

@coveralls
Copy link

coveralls commented Nov 28, 2019

Coverage Status

Coverage remained the same at 94.619% when pulling f51811b on mdupont:358-paragraph-indent into b8346af on PHPOffice:develop.

Documentation contained the wrong unit for Paragraph indentation.
@troosan troosan merged commit 9020e67 into PHPOffice:develop Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Paragraph style hanging
3 participants