Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Which method should listed first? Get or set? #269

Closed
ivanlanin opened this issue Jun 8, 2014 · 2 comments
Closed

Which method should listed first? Get or set? #269

ivanlanin opened this issue Jun 8, 2014 · 2 comments
Assignees
@ivanlanin
Labels
Consulting Request
Milestone
0.12.0

Comments

@ivanlanin
Copy link
Contributor

For consistency, which method should we listed first, get or set? For example, getStyle() vs setStyle(). Currently we mostly listed get first, but there are exceptions, e.g. in Element\Text. Thanks.
@ivanlanin ivanlanin added this to the 0.12.0 milestone Jun 8, 2014
@gabrielbull
Copy link
Member

PhpStorm generates get first and set after, hence the term Getters and Setters. We should use this one by default for consistency. Not that it's that big of a deal :-P.

@ivanlanin
Copy link
Contributor Author

Yes, I know this is not a big deal :D I just need some standard. Thanks for the reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanlanin ivanlanin

Labels
Consulting Request
Milestone
0.12.0
Development

No branches or pull requests
2 participants
@ivanlanin @gabrielbull