Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Html::parseImage when image has no extension #2459

Merged
merged 1 commit into from
Sep 3, 2023
Merged

Fix Html::parseImage when image has no extension #2459

merged 1 commit into from
Sep 3, 2023

Conversation

JokubasR
Copy link
Contributor

@JokubasR JokubasR commented Sep 3, 2023

Description

Allow image from url without extension. Currently it throws an Undefined array key 1 error.

Fixes #2458

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • [] I have updated the documentation to describe the changes

@Progi1984
Copy link
Member

@JokubasR Thank you for your contribution. Could you update the CHANGELOG.md ?

@JokubasR
Copy link
Contributor Author

JokubasR commented Sep 3, 2023

Progi1984 Ok, sure. Hope it's alright now

@Progi1984 Progi1984 added this to the 1.2.0 milestone Sep 3, 2023
@Progi1984 Progi1984 added the HTML label Sep 3, 2023
@Progi1984 Progi1984 merged commit 08f3fa5 into PHPOffice:master Sep 3, 2023
11 of 12 checks passed
@Progi1984
Copy link
Member

@JokubasR Thank you for your contribution 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

Assignees
No one assigned
Labels
HTML
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Allow image from url without extension
2 participants
@JokubasR @Progi1984