Use highest quality for JPEG and PNG images #2318
Conversation
PowerKiKi
force-pushed
the
feature/image-quality
branch
from
468da54
to
8c641e4
Compare
|
@MegaChriz, I pushed the changes I had in mind. Would you mind testing that it still behave as you expect, please ? |
PowerKiKi
force-pushed
the
feature/image-quality
branch
from
8c641e4
to
27b6500
Compare
|
@PowerKiKi Great! I plan to test it this Wednesday. |
src/PhpWord/Element/Image.php
Outdated
| $this->imageExtension = 'png'; | ||
| $this->imageQuality = 0; |
There was a problem hiding this comment.
PNG $quality is the zlib compression level, it is a lossless value. $filters is what enables any lossy compression but it is disabled by default. Setting PNG quality to 0 disables all compression resulting in larger files with no quality benefit.
The default for https://www.php.net/imagepng is -1 which in-turn defaults to the zlib compression default which from the zlib documentation is a quality value of 6
The compression level must be Z_DEFAULT_COMPRESSION, or between 0 and 9: 1 gives best speed, 9 gives best compression, 0 gives no compression at all (the input data is simply copied a block at a time). Z_DEFAULT_COMPRESSION requests a default compromise between speed and compression (currently equivalent to level 6).
Suggest changing the PNG quality value to -1 not 0 in this patch.
|
With the latest changes images fail to render in my case: I'm using the following code for parsing an image (because the image is not publicly available, a cookie is needed to retrieve it): protected static function parseImage($node, $element)
{
$src = $node->attributes->getNamedItem('src')->nodeValue;
$image_attr = [];
$attributes = [
'width',
'height',
];
foreach ($attributes as $key) {
$attribute = $node->attributes->getNamedItem($key);
if ($attribute) {
$image_attr[$key] = $attribute->nodeValue;
}
}
$context = stream_context_create([
'http' => [
'method' => 'GET',
'header' => [
'Cookie: ' . $_SERVER['HTTP_COOKIE']."\r\n",
],
],
]);
try {
return $element->addImage(file_get_contents($src, FALSE, $context), $image_attr);
}
catch (InvalidImageException $e) {
// Log invalid image exceptions.
watchdog_exception('panelsreport', $e);
}
return NULL;
}When trying to debug this, I see that previously the image generation happened in |
PowerKiKi
force-pushed
the
feature/image-quality
branch
from
af66917
to
1afcaab
Compare
This sets the quality of JPEG files to their maximum. It does this by: - defining a property called `$imageQuality` and a method called `getImageQuality()` to PhpOffice\PhpWord\Element\Image - setting the property `$imageQuality` to `100` for JPG, but keep default compression level for PNG - refactor fragile string callbacks into proper closure that use the new `$imageQuality` In the case of a PNG, this is not the _quality_ of the image, but the _filesize_ of the image. So we use the default value for best speed/filesize balance.
PowerKiKi
force-pushed
the
feature/image-quality
branch
from
1afcaab
to
bc3476b
Compare
|
Released as 1.1.0 |
Description
This sets the quality of JPEG and PNG files to their maximum. It does this by:
$imageQualityand a method calledgetImageQuality()to PhpOffice\PhpWord\Element\Image;$imageQualityto100in case of image/jpeg or image/jpg and set it to0in case of image/png;I also added test coverage for PhpOffice\PhpWord\Element\Image::getImageQuality().
Fixes #2317
Checklist:
composer run-script check --timeout=0and no errors were reported