Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Template into TemplateProcessor #216

Closed
ghost opened this issue May 3, 2014 · 4 comments
Closed

Rename Template into TemplateProcessor #216

ghost opened this issue May 3, 2014 · 4 comments

Comments

@ghost
Copy link

ghost commented May 3, 2014

Suggest renaming Template class into TemplateProcessor, because latter matches its purpose the best.

Template is not an instance of the Template class, it's a file on hard drive. The class loads template's content and processes it. Please, take a look at the definition also.

TemplateProcessor class could evolve into a separate component in the future, but, for now, I suggest just renaming.

@ghost ghost added this to the 1.0.0 milestone May 3, 2014
@ghost ghost added Enhancement labels May 3, 2014
@ivanlanin
Copy link
Contributor

I basically agree that TemplateProcessor is better than Template for this class name. I have two other alternatives:

  1. Place the Processor class under Template subnamespace, i.e. Template\Processor
  2. Place the TemplateProcessor under Utility (or other better name) subnamespace. This new subnamespace will hold other utilities such as style importer, format converter, etc.

@ghost
Copy link
Author

ghost commented May 3, 2014

Creating directory just for one class is not a good idea, on my mind, at all. :)

@Progi1984 Progi1984 modified the milestones: 0.12.0, 1.0.0 Jun 2, 2014
@lrobert
Copy link

lrobert commented Jun 5, 2014

I'm not 100% sure but doe this use the Mail Merge functionality? If so it might make sense to use MailMerge as the namespace. Perhaps MailMerge\DocumentProcessor?

@ivanlanin
Copy link
Contributor

The process worked like mail merge, but we don't use mail merge component. Which reminded me that we don't have mail merge component, yet.

@ghost ghost self-assigned this Aug 16, 2014
@ghost ghost closed this as completed Aug 16, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants