Fixes Reader for image styles, tabs and line breaks #2128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abf-jricha
force-pushed
the
develop
branch
9 times, most recently
from
3201684
to
fcea5bd
Compare
abf-jricha
commented
Aug 11, 2021
|
|
||
| // Anchor wrapping style square | ||
| if ($xmlReader->elementExists('wp:anchor/wp:wrapSquare', $domNode)) { | ||
| $styles['wrappingStyle'] = ImageStyle::WRAPPING_STYLE_SQUARE; |
There was a problem hiding this comment.
While testing I've found a problem with the wrapping style. As you see in sample 11. Wrapping styles are not recognized by addImage with styles.
|
Any update on this issue? We still experience those things not working properly. Thanks for your work on it! |
|
No one reviewed the PR. We are still using the forked version in our application and it works fine. |
|
Awesome! Thanks a lot! Hopefully somebody soon reviews the PR... |
Progi1984
force-pushed
the
master
branch
3 times, most recently
from
2d9f999
to
e458249
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes #2127
While loading an existing Word document and save it back, the new document loses the information about the image styles, tabs and line breaks.
Checklist:
composer run-script check --timeout=0and no errors were reported