Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1970 #2221

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #1970 #2221

wants to merge 1 commit into from

Conversation

tontonsb
Copy link

@tontonsb tontonsb commented May 9, 2022

Description

Fixes deleteBlock by using cloneBlock instead of replaceBlock, because it has a better regex.

Fixes #1970

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported — I made the change via GitHub UI and hope that the GitHub workflow will run the tests once I make this PR
  • The new code is covered by unit tests (check build/coverage for coverage report) — no new lines were added
  • I have updated the documentation to describe the changes — no features were added or changed, this is a bug fix

@drupol
Copy link

drupol commented Oct 13, 2022

What's the status of this issue?

@drupol drupol mentioned this pull request Oct 26, 2022
Closed
3 tasks
@PowerKiKi PowerKiKi changed the base branch from develop to master November 16, 2022 21:08
@Progi1984 Progi1984 force-pushed the master branch 3 times, most recently from 2d9f999 to e458249 Compare August 30, 2023 11:56
@Progi1984 Progi1984 added this to the 2.0.0 milestone Nov 30, 2023
@ccerrillo
Copy link

Why isn't this being merged into the 1.2.x branch as a hotfix instead of postponing it until the release of 2.0.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

deleteBlock fails and creates a corrupt doc
4 participants
@tontonsb @drupol @ccerrillo @Progi1984