Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit of setImageValue #1950

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Limit of setImageValue #1950

wants to merge 1 commit into from

Conversation

ponsifiax
Copy link

@ponsifiax ponsifiax commented Oct 21, 2020 •
edited
Loading

Description

When you try to setImage with limit, the processor apply correctly the limit instead replace all tags.

Fixes #1825

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)

@troosan
Copy link
Contributor

troosan commented Feb 7, 2021 •
edited
Loading

I think #1967 is a better fix for this. It actually takes into account the "limit" parameter.
I like the unit tests though ;-) Maybe you can rebase your PR with develop and keep only the unit tests?

@ponsifiax
Copy link
Author

I think too, but maybe keep the unit test to confirm the use case?

@PowerKiKi PowerKiKi changed the base branch from develop to master November 16, 2022 21:15
@Progi1984 Progi1984 force-pushed the master branch 3 times, most recently from 2d9f999 to e458249 Compare August 30, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limit of setImageValue not working
2 participants
@ponsifiax @troosan