Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use style id to link styles with document elements #1788

Closed
wants to merge 1 commit into from
Closed

Use style id to link styles with document elements #1788

wants to merge 1 commit into from

Conversation

begnini
Copy link
Contributor

@begnini begnini commented Dec 26, 2019

Description

Use style id to link styles with document elements, today, the code addresses only the style name.

Fixes #1785

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 94.636% when pulling b67c320 on begnini:using_style_id into 733f845 on PHPOffice:develop.

@PowerKiKi PowerKiKi changed the base branch from develop to master November 16, 2022 21:11
@Progi1984 Progi1984 force-pushed the master branch 3 times, most recently from 2d9f999 to e458249 Compare August 30, 2023 11:56
@begnini begnini closed this Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Word2007 Style Reader not using styleId
2 participants
@begnini @coveralls