Add support for whole-document FootnoteProperties #1704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdupont
force-pushed
the
improv-endnotes
branch
7 times, most recently
from
c81734e
to
6c6a940
Compare
|
Travis mostly good, only fails because of #1706 and because of recent code in the develop branch that was already triggering phpmd warnings. |
mdupont
force-pushed
the
improv-endnotes
branch
from
6c6a940
to
aecde93
Compare
|
Rebased on top of the |
mdupont
force-pushed
the
improv-endnotes
branch
from
aecde93
to
589e746
Compare
mdupont
force-pushed
the
improv-endnotes
branch
from
589e746
to
0a4b25f
Compare
|
@troosan All green now after rebasing on top of the latest commits from |
mdupont
force-pushed
the
improv-endnotes
branch
from
0a4b25f
to
6e109fb
Compare
|
Rebased against 0.17.0 |
Also improves support of these properties for Endnotes.
mdupont
force-pushed
the
improv-endnotes
branch
from
6e109fb
to
e953c8a
Compare
|
Closing since I think it tries to do too many things at once. I will split it in multiple pull requests which improve on 1 thing at a time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improves support of these properties for Endnotes.
Description
It is now possible to set FootnoteProperties for Endnotes at the section level. Previously it only worked for footnotes.
However, since positioning endnotes (for example at the end of the section instead of the end of the document) only works at the document level, I added a way to set default properties for footnotes and endnotes.
Some further work was needed to have both document-level and section-level properties working correctly, as in redeclaring the document-level properties at the section level if need be (this is what Word itself is doing BTW), and omitting to output default properties if the document doesn't have any footnote or endnote.
Fixes #1703
Checklist:
composer run-script check --timeout=0and no errors were reported