Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for comments to reader #2161

Closed

Conversation

shaedrich
Copy link
Contributor

@shaedrich shaedrich commented Nov 2, 2021

Description

Since comments are part of the OOXML spec and I need to build an application that uses comments, I implemented them into phpWord

Fixes #1604 Fixes #622

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@shaedrich
Copy link
Contributor Author

I have run composer run-script check --timeout=0 and no errors were reported

I'm afraid, that list item is a little outdated since the version of php-cs-fixer is:

You are running PHP CS Fixer v2, which is not maintained anymore. Please update to v3.
If you need help while solving warnings, ask at https://gitter.im/PHP-CS-Fixer, we will help you!

@shaedrich shaedrich marked this pull request as ready for review November 2, 2021 18:15
@shaedrich
Copy link
Contributor Author

Can somebody help with this?

@PowerKiKi PowerKiKi changed the base branch from develop to master November 16, 2022 21:15
@Progi1984 Progi1984 force-pushed the master branch 3 times, most recently from 2d9f999 to e458249 Compare August 30, 2023 11:56
@Progi1984
Copy link
Member

Superseeded by #2469

@Progi1984 Progi1984 closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Word2007 reader/writer is loosing information Reader/writer for Comments and Track-changes document parts
2 participants