Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gracefully handle absent href attribute when parsing links #2280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gracefully handle absent href attribute when parsing links #2280

wants to merge 1 commit into from

Conversation

asmundstavdahl
Copy link

Description

Previously, an 'Invalid parameters passed' error would be emitted when parsing an "a" element without an "href" attribute. This fix lets href-less links through. Thanks to @santerref of #1562 for this fix.

Fixes #1562

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
    • There were errors, but they are not caused by the changes in this PR and should be fixed separately IMHO
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
    • I could not find a suitable place to document it, and also this is a fix for existing functionality and should not need to be documented.

@PowerKiKi PowerKiKi changed the base branch from develop to master November 16, 2022 21:08
@Progi1984 Progi1984 force-pushed the master branch 3 times, most recently from 2d9f999 to e458249 Compare August 30, 2023 11:56
@Progi1984 Progi1984 added this to the 2.0.0 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

A tag without href causes error in Rels
2 participants
@asmundstavdahl @Progi1984