Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis-CI status in readme needs to be for master branch and ammending commits when necessary #143

Closed
gabrielbull opened this issue Mar 18, 2014 · 1 comment
Milestone

Comments

@gabrielbull
Copy link
Member

Hi @ivanlanin ,

I would have sent you this by email but I do not have your address, maybe you can get in touch with me by email so I can add you to my contacts.

I will revert your changes to the develop branch concerning the travis-ci status in the readme that now gives the status of the develop branch instead of the master branch. There is really no point in having the develop branch status in the readme as it is not relevant for users using PHPWord and might be from time to time on the "Build fail" status while the master branch should always be on the "Pass" status.

Also, I wanted to take the time to tell you about amend commits that allow you to make 1 commit for a change instead of 4.

@ivanlanin
Copy link
Contributor

Hi @gabrielbull. I've sent you an email.

Ok, I think you're right. We should display the status of the stable branch.

Thanks for the info about amend commits. I'll do it next time.

@Progi1984 Progi1984 added this to the 0.9.0 milestone Mar 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants