Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release #1174

Closed
Charius opened this issue Oct 27, 2017 · 9 comments
Closed

New release #1174

Charius opened this issue Oct 27, 2017 · 9 comments

Comments

@Charius
Copy link

Charius commented Oct 27, 2017

So when there will be next release. Since now there are 100+ commits in develop branch and no release. It's sad.

@FBnil
Copy link

FBnil commented Oct 27, 2017

Charius, we do not have an official maintainer (if you want you can apply for that position). There are lots of patches, and they all need to be tested, marked as useful, marked as incomplete or missing functions, or missing testcases (which you can pull-request to those, before they get merged into PHPWord), etc. That work can be done by enthousiasts like us. For example: there are 3 versions of TemplateProcessor Images insertions. Which would you choose? Just go into the patches, test them, and comment on their usefulness, the name of the functions, the ideas to make it easier on the user later on, this way the patch gets better.

@Charius
Copy link
Author

Charius commented Oct 27, 2017

@FBnil thanks for the answer and information!

@Charius
Copy link
Author

Charius commented Oct 30, 2017

this issue related with #848

So I close this one

@Charius Charius closed this as completed Oct 30, 2017
@dac514
Copy link

dac514 commented Nov 2, 2017

@FBnil

we do not have an official maintainer

What about this comment?

#948 (comment)

I see @troosan in the dev branch. It would be nice to get some clarification. I'm starting to lose my confidence in this project.

@Charius
Copy link
Author

Charius commented Nov 2, 2017

@connerbw the situation is really interesting, thanks for your comment. Maybe @troosan or @FBnil will clarify this for all of us.

@FBnil
Copy link

FBnil commented Nov 2, 2017

@connerbw @Charius hmm... you are quite right, I have been spreading lies. (which means I need to read closed messages too...).
My apologies @troosan ! @troosan has been committing and closing steadily through the months see the closing dates for
Closed issues for milestone 0.14.0
... a bit of a quiet person (but replying to issues is not the task of the maintainer). Now, it looks like all bugs (marked for that milestone) are closed, but the sourcecode in dev Still shows some nasty errors https://scrutinizer-ci.com/g/PHPOffice/PHPWord/issues which need to be cleaned up a bit.

Which also leaves us with a heap of pull requests and feature requests that could be considered part of the core. pushed to the next milestone... far into the future.

@FBnil
Copy link

FBnil commented Nov 2, 2017

I have updated my profile picture accordingly. (oh, the shame)

@troosan
Copy link
Contributor

troosan commented Nov 7, 2017

Hi, indeed, I'm not as volubile as @FBnil :-) (thanks for the support BTW)
Anyway, I'm trying to go through the PR (there are a lot) and integrating the ones that can easily be merged and that do not risk breaking to much things.

As you can see I updated the copyright to 2010-2017, so I'm still hoping to publish 0.14 as a Christmas present!

After that I guess we'll have to have a release dedicated to all the nice changes done on the TemplateProcessor. I'm a bit nervous about those changes as there is virtually 0 unit tests covering that part.

@Charius
Copy link
Author

Charius commented Nov 9, 2017

@troosan thanks for your response, glad to see your answer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants