Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace trigger_error #113

Closed
Progi1984 opened this issue Mar 12, 2014 · 4 comments
Closed

Replace trigger_error #113

Progi1984 opened this issue Mar 12, 2014 · 4 comments
Labels
Change Request
Milestone
0.8.0

Comments

@Progi1984
Copy link
Member

PHPWord calls actually a lot of trigger_error. Is that the right way would be to use PHPWord_Exception ? That would permit to unit tests errors.

CC : @ivanlanin @gabrielbull
@Progi1984 Progi1984 added this to the 0.7.3 milestone Mar 12, 2014
@gabrielbull
Copy link
Member

No, you made the right call, we should use throw new Exception and make custom exceptions in the Exceptions directory as much as possible

@ivanlanin
Copy link
Contributor

I agree. I've made one changes from trigger_error to Exception on #112. I'll continue making changes as I made more unit tests.

@ivanlanin
Copy link
Contributor

This is all remaining trigger_error: 2f0438f

@ivanlanin ivanlanin mentioned this issue Mar 13, 2014
Merged
@ivanlanin
Copy link
Contributor

@Progi1984 I think this issue can be closed.

@Progi1984 Progi1984 modified the milestones: 0.7.1, 0.7.3 Mar 14, 2014
@Progi1984 Progi1984 modified the milestones: 0.7.3, 0.7.1 Mar 14, 2014
@Progi1984 Progi1984 added this to the 0.8.0 milestone Mar 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Change Request
Milestone
0.8.0
Development

No branches or pull requests
3 participants
@ivanlanin @gabrielbull @Progi1984