Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You forgot to bump the PHPMailer Version to 5.2.6 #45

Closed
ooxi opened this issue Apr 17, 2013 · 2 comments
Closed

You forgot to bump the PHPMailer Version to 5.2.6 #45

ooxi opened this issue Apr 17, 2013 · 2 comments

Comments

@ooxi
Copy link

ooxi commented Apr 17, 2013

Hi,

while the tag clearly states the 5.2.6 release, the sourcecode of class.phpmailer.php still refers to itself as 5.2.5 while class.smtp.php remained at 5.2.4

@Synchro
Copy link
Member

Synchro commented Apr 17, 2013

Hm. They were all updated to 5.2.6 but for some reason it looks like the tag was attached to an earlier commit, which is weird since it wasn't added (or even committed) until after all the version bumps.

The git docs don't say which commit a tag applies to by default - the one previous to its creation, or the one contained by it - I found that very confusing, as you can see!

@Synchro
Copy link
Member

Synchro commented Apr 17, 2013

I've reattached the tag to the right commit, thanks for the heads-up.

@Synchro Synchro closed this as completed Apr 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants