We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using LoggerInterface, I don't see why we should have the SMTP::LE chars passed to the debug method
protected function edebug($str) { ... if ($this->Debugoutput instanceof \Psr\Log\LoggerInterface) { $this->Debugoutput->debug($str); return; }
In my case, with Monolog\Formatter\LineFormatter and a $allowInlineLineBreaks = true, I was seeing logs with an empty line between each log line
[2024-03-14T15:44:05.083183+00:00] logger.DEBUG: CLIENT -> SERVER: [2024-03-14T15:44:05.083250+00:00] logger.DEBUG: CLIENT -> SERVER: . [2024-03-14T15:44:05.247371+00:00] logger.DEBUG: CLIENT -> SERVER: QUIT
Setting $allowInlineLineBreaks to false solved it but I don't thing this is usefull.
Using same preg_replace as 'html' and 'echo' cases would give this:
if ($this->Debugoutput instanceof \Psr\Log\LoggerInterface) { $this->Debugoutput->debug(preg_replace('/[\r\n]+/', '', $str)); return; }
Should I propose a PR for that ?
The text was updated successfully, but these errors were encountered:
Yes, that seems reasonable, go ahead with a PR.
Sorry, something went wrong.
Merge pull request #3047 from axi/#3045
400aeae
Remove potential ending line break when using edebug() with LoggerInterface
No branches or pull requests
Problem description
Using LoggerInterface, I don't see why we should have the SMTP::LE chars passed to the debug method
In my case, with Monolog\Formatter\LineFormatter and a $allowInlineLineBreaks = true, I was seeing logs with an empty line between each log line
Setting $allowInlineLineBreaks to false solved it but I don't thing this is usefull.
Using same preg_replace as 'html' and 'echo' cases would give this:
Should I propose a PR for that ?
The text was updated successfully, but these errors were encountered: