Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default pattern for validateAddress() #226

Closed
dregad opened this issue May 1, 2014 · 0 comments
Closed

Default pattern for validateAddress() #226

dregad opened this issue May 1, 2014 · 0 comments

Comments

@dregad
Copy link
Contributor

dregad commented May 1, 2014

I really like what you did with validateAddress() method selection in 5.2.7.

If I may make a suggestion, I think it would be better when $patternselect is not one of the accepted value, if the function fell back to auto instead of php.

(I had a case where I mistakenly passed null instead of auto and it took me some time to understand why user@localhost was rejected)

@Synchro Synchro closed this as completed in e6d7f38 May 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant