Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically fix PHP errors on pull requests #1342

Closed
ghost opened this issue Jan 25, 2018 · 4 comments
Closed

Automatically fix PHP errors on pull requests #1342

ghost opened this issue Jan 25, 2018 · 4 comments

Comments

@ghost
Copy link

ghost commented Jan 25, 2018

I run Stickler-CI which is a service aimed at improving code quality by simplifying code review by automating code feedback in pull requests.

We just launched auto-fixing for PHP through pull request commits. As a PHP open source project, our service will save you time and brain power by automatically fixing style errors.

If you are interested in trying out our product, we can submit a pull request with the configuration file, but a maintainer will need to enable webhooks by logging into https://stickler-ci.com and enabling the webhook.

Thank you!

@halfer
Copy link

halfer commented Jan 31, 2018

Cheeky, but I appreciate as a start-up owner, one has to try everything to gain traction. 😉

I've no association with the project, other than as a user, but could you analyse some current/past PRs to show what sort of suggestions your product would make? If they are really good, maybe you'd get some bites.

@Synchro
Copy link
Member

Synchro commented Jan 31, 2018

We've already got fairly tight phpcs config that's enforced on PRs, and also have scrutinizer-ci configured, so it sounds like we already have quite a lot of the same stuff covered already. I'm not that big a fan of auto-fixing as I've seen it make too many mistakes. What advantages do you have over those?

@ghost
Copy link
Author

ghost commented Jan 31, 2018

I am cheeky, and persistent 😉. Let me get you some examples from my tech partner. Stay tuned!

@ghost
Copy link
Author

ghost commented Feb 1, 2018

Hello again!

I have an example of how our product works. Take a look at this PR thread:

cakephp/cakephp#11645

If you dive deeper into the second commit, which has the fixes, you can see how it works in a more detailed fashion:

cakephp/cakephp@c259c72

However, if your current service already performs these fixes, I am wondering if you have any other code quality issues that aren't being met by your current product. If so, we can discuss how we might be able to fill that gap 😊.

Cheers,

Tara

@Synchro Synchro closed this as completed Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants