Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json merge #586

Merged
merged 5 commits into from
Nov 15, 2018
Merged

Json merge #586

merged 5 commits into from
Nov 15, 2018

Conversation

doutriaux1
Copy link
Contributor

@lee1043 this one is for you it allows to merge multiple level of the json_structure into a single dimension.
@durack1 @gleckler1 please review as well.
@zshaheen I wouldn't mind you taking a look either to double check all my crazy transpose and recursive functions.
We will need this for the click_portrait.

@doutriaux1
Copy link
Contributor Author

@lee1043 look at tests to see how I join multiple dimensions together.

@coveralls
Copy link

coveralls commented Nov 9, 2018

Pull Request Test Coverage Report for Build 749

  • 139 of 143 (97.2%) changed or added relevant lines in 2 files are covered.
  • 17 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.3%) to 74.492%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pcmdi_metrics/io/base.py 100 104 96.15%
Files with Coverage Reduction New Missed Lines %
pcmdi_metrics/io/base.py 1 90.0%
tests/basepmpdriver.py 1 90.63%
tests/basepmp.py 15 55.32%
Totals Coverage Status
Change from base Build 743: 0.3%
Covered Lines: 2935
Relevant Lines: 3940

💛 - Coveralls

@doutriaux1
Copy link
Contributor Author

@lee1043 @gleckler1 @durack1 ready for review

@doutriaux1 doutriaux1 merged commit 9cf5870 into master Nov 15, 2018
@doutriaux1 doutriaux1 deleted the json_merge branch November 15, 2018 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants