-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand attributes in metrics output json file: creation date, tracking id and climfilename.nc #50
Comments
@gleckler1 you mean the name of climatology file used to compute the metrics? |
Yes, the name of the climatology used to compute the metrics! |
so NOAA-OISST-v2 (tos) or GPCP (pr) etc etc |
@gleckler1 if you can clearly define what needs to be done here, I can implement the changes and close this up - it's not dependent on @doutriaux1 or UV-CDAT changes.. The md5sums in an updated observation json dictionary should also be done |
@durack1 , look at src/python/pcmdi/scripts there is a script in there that @gleckler1 wrote that generates the obs dict. This is where it needs to sit eventually. |
Ok so https://github.com/PCMDI/pcmdi_metrics/blob/master/src/python/pcmdi/scripts/build_obs_meta_dictionary.py - and will need calls to md5sum |
@gleckler1 is this done - is the issue close-able? |
Following the 24th Sept 2014 email to GFDL the following improvements were listed: |
Can we make this one a high priority? I've looked at it, but right now this one is too hard for me... the hope is that each metrics json file, for each model will include the following:
|
@gleckler1 so to clarify, what you're asking for is the files that are being interrogated to create the results in the CMIP_results/CMIP5/historical *.json also contain the 3 attributes above? Which file that you run (and is in the repo) creates these jsons? |
Don't quite follow you but I think yes... the metrics json files should include of for each model/climatology these 3 attributes... e.g. |
@gleckler1 are you talking about the files that we provide (so those in CMIP_results), or the output files that are created by the GFDL, NCAR or whoever folks? This only makes sense to me for us to do this, as we have the CF-compliant CMIP5 data that we're using to create the CMIP3/5 metrics benchmarks stored in CMIP_results.. |
If the first one (files that @gleckler1 creates), where is that script? Is it in the repo? |
creation date is simtrackingdate there's an alias for that, we can take the alias out, it was originally designed after Jerome's recommendation as it was deemed ok for a first pass. |
@gleckler1 the md5sum of the climatology file is kinda arbitrary, as we are creating this climatology from the CMIP5 data that we have stored locally - would it be more useful to include more specific information which is obtained from the source files from which the climatology has been generated? We could include both pieces of information, source files (filename, creation_date, tracking_id) and also info about the derived climatology file (filenameandpath, clim_creation_date - which will be dependent on whom created the file and whether they wrote suitable attributes) |
UPDATE I am taking care of all other attributes (CMIP5_creation_date and CMIP5_tracking_id) |
For each variable/json file ...
Add to both models (under "SimulationDescription") and observations the following keys (both of which can be obtained from the netCDF files...
The text was updated successfully, but these errors were encountered: