-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Update portrait_plot_lib #1077
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem?
In portrait_plot_lib.py, prepare_data() (lines 343-387), NaN values are masked out and replaced with 1e20, showing interactive portrait plot tooltip values as 0 and glyphs in yellow.
Describe the solution you'd like
Values should remain NaN to use bokeh parameter
nan_color=missing_color
. Tooltip values should be NaN and glyphs should be missing_color (grey). I propose removing line 385 that creates a masked array. This is not necessary as other functions (i.e., normalize_by_median() ) already ignore NaNs.Describe alternatives you've considered
I considered setting the masked array fill value to NaN, but this does not correctly map the glyphs to the correct color and is likely redundant.
Additional context
No response
The text was updated successfully, but these errors were encountered: