Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option for User of ozone to specify a path to output directory for any files (csv, json, xlsl) that might be created #89

Closed
Samxx97 opened this issue Mar 25, 2022 · 1 comment · Fixed by #92
Assignees
Labels
enhancement New feature or request

Comments

@Samxx97
Copy link
Contributor

Samxx97 commented Mar 25, 2022

@Milind220 while writing the tests i noticed that running the _format_output() generates files in the current directory of the code , i think it would be better if the user himself can choose the location of the output of such files like csv or json or any future files that ozone might create.

the best way this can be done in my opinion is by adding a property output_dir to the class ozone itself , and this is a better approach than adding it as a parameter to each public function, since the user can choose his output directory when instantiating the ozone class itself and it would be used by all functions that need it.

@Samxx97 Samxx97 added the enhancement New feature or request label Mar 25, 2022
@Samxx97
Copy link
Contributor Author

Samxx97 commented Mar 25, 2022

Hold my beer, I got this

@Samxx97 Samxx97 changed the title Add Option for User of ozone to specify an output directory for any files (csv, json, xlsl) that might be created Add Option for User of ozone to specify a path to output directory for any files (csv, json, xlsl) that might be created Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants