Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking change]: Remove save data to file functionality #154

Closed
Milind220 opened this issue May 13, 2022 · 1 comment · Fixed by #159
Closed

[Breaking change]: Remove save data to file functionality #154

Milind220 opened this issue May 13, 2022 · 1 comment · Fixed by #159
Labels
bug Something isn't working urgent Important fix/addition that should be addressed asap
Milestone
version 3.0

Comments

@Milind220
Copy link
Collaborator

Describe the change

Ozone offers some functionality to save data to CSV, Excel, or JSON files. However, this has introduced some messy code, a bug, and some very unintuitive ways of setting a save file name.

More importantly, we've realised that offering the functionality to save to a file Is unnecessary. A user could, with a single Pandas method (eg: dataframe.to_csv), save their data to a file themselves. This is also exactly what Ozone currently does anyway.

The proposed solution

Note: This was mentioned in 'option 1' of the comment by @lahdjirayhan in #151 (comment)

To remove the file saving features entirely.
@Milind220 Milind220 added the bug Something isn't working label May 13, 2022
@Milind220 Milind220 added this to the version 3.0 milestone May 13, 2022
@Milind220 Milind220 added the urgent Important fix/addition that should be addressed asap label May 13, 2022
@Milind220
Copy link
Collaborator Author

hold my beer, I got this

@Milind220 Milind220 changed the title [Breaking change for version 3.0] [Breaking change]: Remove save data to file functionality May 23, 2022
@Milind220 Milind220 linked a pull request May 23, 2022 that will close this issue
[Breaking Change]: Remove save file func #159
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working urgent Important fix/addition that should be addressed asap
Projects
None yet
Milestone
version 3.0
Development

Successfully merging a pull request may close this issue.

[Breaking Change]: Remove save file func Ozon3Org/Ozon3
1 participant
@Milind220