Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labware Position Check: Extend section list component for generic step screen #8500

Closed
3 tasks
shlokamin opened this issue Oct 11, 2021 · 0 comments · Fixed by #8513
Closed
3 tasks

Labware Position Check: Extend section list component for generic step screen #8500

shlokamin opened this issue Oct 11, 2021 · 0 comments · Fixed by #8513
Assignees
Labels
app Affects the `app` project

Comments

@shlokamin
Copy link
Member

shlokamin commented Oct 11, 2021

Overview

In the generic step screen we need to use the same section list component as the intro screen, but it needs to be extended so that...

(1) Uncompleted sections are dimmed
(2) Completed sections have a green checkbox around the section number

The same highlight functionality as the intro screen should exist where the current section should be highlighted.

Implementation Details

Extend the component to take in props to tell the component:

(1) Which sections are completed
(2) Which section is active

Using these this information, we can infer which sections are incomplete.

When a section is completed, render a green check mark on top of the section number (the icon name is "check-circle"), with the section name being black
When a section is active, both the section number and section name should be highlighted with C_SELECTED_DARK
When a section is incomplete, both the section number and section name should be dimmed with C_DISABLED

Design

See this figma node

Acceptance criteria

  • Uncompleted sections are dimmed
  • Completed sections have a green checkbox around the section number
  • Current active section is highlighted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants