Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protocol engine: Basic JSON protocol upload over HTTP #7816

Closed
3 tasks
sanni-t opened this issue May 17, 2021 · 2 comments · Fixed by #7856
Closed
3 tasks

Protocol engine: Basic JSON protocol upload over HTTP #7816

sanni-t opened this issue May 17, 2021 · 2 comments · Fixed by #7856
Labels
robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Milestone
CPX Sprint 33

Comments

@sanni-t
Copy link
Member

sanni-t commented May 17, 2021

Overview

As an OT-2 user, I want to use an HTTP endpoint to send a single basic JSON protocol file to the robot.
Related to: #7808

Acceptance criteria

  • a /protocol_upload http POST endpoint that is able to fetch the protocol file as form data
  • the robot-server, upon receiving the request with the file, sends the file to Protocol runner which translates, extracts metadata and returns appropriate response* data to robot-server. The protocol runner does all things necessary to prepare the protocol in order to be run using P.E (covered in another ticket.)
  • *Appropriate response to robot-server should include:
  • Metadata
  • Labware
  • Handles to get:
    -- Labware definitions
    -- Protocol steps (Run log)
    -- Start protocol (or protocol session)

Out of scope for this ticket

  • Features related to protocol simulation. Since this ticket relates to JSON protocols only, we should be able to implement the protocol upload w/o simulation.
@sanni-t sanni-t added the robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). label May 17, 2021
@mattwelch mattwelch added this to the CPX Sprint 33 milestone May 18, 2021
@amitlissack
Copy link
Contributor

Important to keep in mind that this functionality already exists in the robot-server.

This was referenced Jun 1, 2021
Merged
Merged
Merged
Merged
@mcous
Copy link
Contributor

mcous commented Jun 2, 2021

This ticket was implemented by standing up a separate, feature-flagged router to avoid collision with any of the existing (working) HTTP protocol upload beta stuff.

All stuff about "metadata" in the original ticket was punted on in favor of a separate ticket about protocol simulation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Milestone
CPX Sprint 33
Development

Successfully merging a pull request may close this issue.

refactor(robot-server): add experimental protocol router Opentrons/opentrons
4 participants
@mattwelch @mcous @amitlissack @sanni-t