Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App & API: Map Legacy Commands to v6 JSON commands #11187

Closed
3 tasks
b-cooper opened this issue Jul 20, 2022 · 0 comments · Fixed by #11296
Closed
3 tasks

App & API: Map Legacy Commands to v6 JSON commands #11187

b-cooper opened this issue Jul 20, 2022 · 0 comments · Fixed by #11296
Assignees
@b-cooper @smb2268 @sakibh
Labels
api Affects the `api` project app Affects the `app` project papi-v2 Python API V2

Comments

@b-cooper
Copy link
Contributor

b-cooper commented Jul 20, 2022 •
edited by smb2268
Loading

#Overview

To support higher fidelity parsing/tracking of PAPIv2/JSONv5 protocols, let's extend the LegacyCommandMapper class to support the following legacy command types:

  • (grabbed by Sakib) aspirate
  • (grabbed by ----) dispense
  • (grabbed by ----) blowout
    ...

#Required steps for each command

  • handle before and after stage messages published per legacy command type in the legacy_command_mapper.py file
  • add test coverage per legacy command type to test_legacy_command_mapper.py
@b-cooper b-cooper added api Affects the `api` project app Affects the `app` project papi-v2 Python API V2 labels Jul 20, 2022
@jerader jerader mentioned this issue Aug 5, 2022
Merged
4 tasks
jerader added a commit that referenced this issue Sep 14, 2022
@jerader @b-cooper
@sakibh @smb2268
feat(app, api): map PAPIv2 liquid handling commands to JSON v6 comman…
ccca75f 
…ds (#11296)

closes #11187 & RSS-61

Co-authored-by: Brian Cooper <[email protected]>
Co-authored-by: Sakib Hossain <[email protected]>
Co-authored-by: smb2268 <[email protected]>
sfoster1 pushed a commit that referenced this issue Oct 21, 2022
@jerader @b-cooper
@sakibh @smb2268 @sfoster1
feat(app, api): map PAPIv2 liquid handling commands to JSON v6 comman…
a19104f 
…ds (#11296)

closes #11187 & RSS-61

Co-authored-by: Brian Cooper <[email protected]>
Co-authored-by: Sakib Hossain <[email protected]>
Co-authored-by: smb2268 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b-cooper b-cooper

@smb2268 smb2268

@sakibh sakibh

Labels
api Affects the `api` project app Affects the `app` project papi-v2 Python API V2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(app, api): map PAPIv2 liquid handling commands to JSON v6 commands Opentrons/opentrons
3 participants
@b-cooper @smb2268 @sakibh