6.0 Feedback: App side analysis failing when custom labware folder has many files

[shlokamin]

Overview

When the custom labware directory in app settings has many files, app side analysis fails with an opaque error of Maximum call stack exceeded.

Upon further investigation, I found that it came from this line of code in app-shell/src/protocol-analysis/index.ts :

  const auxLabwareDirContents = globby.sync(
    path.posix.join(getConfig().labware.directory, '**')
  )

The code above has been changed in the 6.0 release branch, but the replacement code still does not have a depth limit.

Since this seems like it might be something that a nontrivial amount of users might experience, we should evaluate adding a depth limit.

Also, it's worth noting this same error probably happens on the labware page in the app, because that page does the same logic to grab custom labware.

Current Behavior

App side analysis fails when custom labware dir has many files with an opaque error.

Expected Behavior

Not sure, but at the very least we should get a better error

Steps To Reproduce

In app settings, make your custom labware dir a folder that has many files. In my case, I had a ton of screenshots.

Operating system

No response

Robot setup or anything else?

No response