Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6.0 Feedback: 6.0.0-alpha.0 Recent protocol runs are missing clickable items #10502

Closed
emilywools opened this issue May 27, 2022 · 1 comment · Fixed by #10537
Closed

6.0 Feedback: 6.0.0-alpha.0 Recent protocol runs are missing clickable items #10502

emilywools opened this issue May 27, 2022 · 1 comment · Fixed by #10537
Assignees
@y3rsh @nusrat813 @jerader
Labels
6.0-feedback Feedback for the 6.0 release complete Completely resolved and/or verified fixed.

Comments

@emilywools
Copy link

emilywools commented May 27, 2022 •
edited
Loading

Overview

on the robot detail page, the recent protocol runs displays each run as a row. run and protocol should be clickable.

run should go to the run record page
protocol should go to the protocol detail page
Screen Shot 2022-05-27 at 9 31 50 AM

AC
Edge case: if a user no longer has the protocol in their app directory, we wont be able to take them to the protocol detail page. In this case, the protocol item will not be clickable in that case.

Current Behavior

No response

Expected Behavior

No response

Steps To Reproduce

No response

Operating system

No response

Robot setup or anything else?

No response
@emilywools emilywools added the 6.0-feedback Feedback for the 6.0 release label May 27, 2022
@jerader jerader self-assigned this May 31, 2022
jerader added a commit that referenced this issue May 31, 2022
@jerader
feat(app): make protocol runs from history clickable
8750d7e 
closes #10502
@jerader jerader mentioned this issue May 31, 2022
Merged
jerader added a commit that referenced this issue May 31, 2022
@jerader
feat(app): make protocol runs from history clickable
6965cae 
closes #10502
jerader added a commit that referenced this issue Jun 1, 2022
@jerader
feat(app): make protocol runs from history clickable (#10537)
b98abee 
closes #10502
@nusrat813 nusrat813 added the complete Completely resolved and/or verified fixed. label Jun 7, 2022
@nusrat813
Copy link

Verified fix

Correct behavior - correct behavior is when you delete a protocol, the protocol name is not clickable but the run is clickable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@y3rsh y3rsh

@nusrat813 nusrat813

@jerader jerader

Labels
6.0-feedback Feedback for the 6.0 release complete Completely resolved and/or verified fixed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(app): make protocol runs from history clickable Opentrons/opentrons
5 participants
@y3rsh @bndo @emilywools @nusrat813 @jerader