Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

robot-server: "reset" stored runs #10238

Closed
2 tasks
mcous opened this issue May 9, 2022 · 1 comment · Fixed by #10395
Closed
2 tasks

robot-server: "reset" stored runs #10238

mcous opened this issue May 9, 2022 · 1 comment · Fixed by #10395
Assignees
@TamarZanzouri
Labels
robot server Affects the `robot-server` project robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).

Comments

@mcous
Copy link
Contributor

mcous commented May 9, 2022 •
edited by SyntaxColoring
Loading

Overview

As an HTTP API client, I'd like to reset the state of my robot's run history. This supports the UI #8792.

Acceptance criteria

  • Factory reset slide-out in app includes "Run history"
    • This UI is driven by the endpoint
  • Removing "run history" removes all stored runs, protocols, and analyses

Implementation notes

  • The best way to implement is likely to remove and re-create the database entirely.
    • Edit @SyntaxColoring: I agree with this, but we should make sure there won't be any problems with deleting the database and protocols directory while it's in use.
@mcous mcous added robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). robot server Affects the `robot-server` project labels May 9, 2022
@mcous mcous mentioned this issue May 17, 2022
Merged
@TamarZanzouri
Copy link
Contributor

TamarZanzouri commented May 17, 2022 •
edited by aptrons22
Loading

meeting notes with @SyntaxColoring:

  1. add reset runs option in route:
    '/settings/reset/options'
    mark option as reset after
  2. after adding the option to the list
    change route '/settings/reset'
    to accept the option id set to true
  3. move logic to a collaborator class? if its api level use api reset() else mark db file to delete

DB actions should include:
on robot reboot drop the DB\delete file

@aptrons22 aptrons22 removed their assignment May 17, 2022
@TamarZanzouri TamarZanzouri self-assigned this May 18, 2022
@TamarZanzouri TamarZanzouri mentioned this issue May 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TamarZanzouri TamarZanzouri

Labels
robot server Affects the `robot-server` project robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(robot-server): add runs history removal to reset options Opentrons/opentrons
3 participants
@mcous @TamarZanzouri @aptrons22