Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine BaseModal and Modal into one component and update design #9578

Closed
3 tasks
jerader opened this issue Feb 25, 2022 · 0 comments
Closed
3 tasks

Combine BaseModal and Modal into one component and update design #9578

jerader opened this issue Feb 25, 2022 · 0 comments
Assignees

Comments

@jerader
Copy link
Collaborator

jerader commented Feb 25, 2022

Overview

Both Modal and BaseModal are used similarly (and in some cases are interchangeable) but each of them have a few unique props.

Combine Modal and BaseModal in a way that also updates both of them to match designs, remove the usage of style sheets, and keep necessary props.

Note: a new Modal in atoms has already been made that uses baseModal, so probably should combine all 3.

Design

https://www.figma.com/file/bVtCogdwiXj3ndpk4AWXCx/Milestone-1%3A-Read-and-Execute?node-id=258%3A60335

Implementation Details

Props should be:

  • header
  • footer
  • noHeaderStyles
  • onCloseClick
  • children
  • alertOverlay
  • restrictOuterScroll

Overlay background + styling should come from Overlay component

Acceptance criteria

  • Modal and BaseModal should be combined into 1
  • it should match designs
  • update relevant tests and stories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant