We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Both Modal and BaseModal are used similarly (and in some cases are interchangeable) but each of them have a few unique props.
Modal
BaseModal
Combine Modal and BaseModal in a way that also updates both of them to match designs, remove the usage of style sheets, and keep necessary props.
Note: a new Modal in atoms has already been made that uses baseModal, so probably should combine all 3.
atoms
baseModal
https://www.figma.com/file/bVtCogdwiXj3ndpk4AWXCx/Milestone-1%3A-Read-and-Execute?node-id=258%3A60335
Props should be:
Overlay background + styling should come from Overlay component
Overlay
The text was updated successfully, but these errors were encountered:
refactor(app): update in app Modal component
96924f5
closes #9578
b5144a9
jerader
Successfully merging a pull request may close this issue.
Overview
Both
Modal
andBaseModal
are used similarly (and in some cases are interchangeable) but each of them have a few unique props.Combine
Modal
andBaseModal
in a way that also updates both of them to match designs, remove the usage of style sheets, and keep necessary props.Note: a new
Modal
inatoms
has already been made that usesbaseModal
, so probably should combine all 3.Design
https://www.figma.com/file/bVtCogdwiXj3ndpk4AWXCx/Milestone-1%3A-Read-and-Execute?node-id=258%3A60335
Implementation Details
Props should be:
Overlay background + styling should come from
Overlay
componentAcceptance criteria
Modal
andBaseModal
should be combined into 1The text was updated successfully, but these errors were encountered: