From ce48611d4c1c710f3e28f26a31b45bc218fb9f5a Mon Sep 17 00:00:00 2001 From: pmoegenburg Date: Tue, 18 Jun 2024 17:23:56 +0000 Subject: [PATCH] fix(app-testing): snapshot failure capture --- ...P300M_P20S_HS_TC_TM_dispense_changes].json | 20 +- ...InRTP_Override_wrong_type_in_maximum].json | 2 +- ...2_15_P300M_P20S_HS_TC_TM_SmokeTestV3].json | 20 +- ...IP_HS_MB_TC_TM_IlluminaDNAEnrichment].json | 265 +++---- ..._HS_MB_TC_TM_IlluminaDNAEnrichmentv4].json | 720 +++++++----------- ...HS_HeaterShakerConflictWithTrashBin2].json | 2 +- ...InRTP_Override_wrong_type_in_minimum].json | 2 +- ...18_NO_PIPETTES_DescriptionTooLongRTP].json | 5 +- ...P_Override_default_less_than_minimum].json | 2 +- ...T2_S_v2_18_NO_PIPETTES_GoldenRTP_OT2].json | 95 +-- ...2_16_P300M_P20S_HS_TC_TM_SmokeTestV3].json | 20 +- ...P300M_P20S_HS_TC_TM_dispense_changes].json | 20 +- ...Override_wrong_type_in_variable_name].json | 2 +- ...verride_default_greater_than_maximum].json | 2 +- ...ride_int_default_no_matching_choices].json | 2 +- ...][Flex_S_v2_18_NO_PIPETTES_GoldenRTP].json | 95 +-- ...pesInRTP_Override_wrong_type_in_unit].json | 2 +- ...HS_HeaterShakerConflictWithTrashBin1].json | 2 +- ...ride_str_default_no_matching_choices].json | 8 +- ...de_wrong_type_in_choice_display_name].json | 2 +- ...de_float_default_no_matching_choices].json | 2 +- ...2_14_P300M_P20S_HS_TC_TM_SmokeTestV3].json | 20 +- ...5_P50M_P1000M_KAPALibraryQuantLongv2].json | 430 +++++------ ...P_Override_wrong_type_in_description].json | 2 +- ...6_GRIP_HS_MB_TC_TM_IDTXgen96Part1to3].json | 30 +- ...lex_X_v2_18_NO_PIPETTES_ReservedWord].json | 2 +- ..._Override_wrong_type_in_choice_value].json | 2 +- ...P1000S_None_SimpleNormalizeLongRight].json | 190 ++--- ...2_17_P300M_P20S_HS_TC_TM_SmokeTestV3].json | 20 +- ...v2_18_None_None_duplicateChoiceValue].json | 5 +- ...S_TC_TrashBinAndThermocyclerConflict].json | 2 +- ...InRTP_Override_wrong_type_in_default].json | 2 +- ..._GRIP_HS_MB_TC_TM_IlluminaDNAPrep24x].json | 165 ++-- ...P_HS_MB_TC_TM_IlluminaDNAPrep96PART3].json | 5 +- ..._Override_wrong_type_in_display_name].json | 2 +- ...P300M_P20S_HS_TC_TM_dispense_changes].json | 20 +- 36 files changed, 879 insertions(+), 1308 deletions(-) diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[041ad55e7b][OT2_S_v2_15_P300M_P20S_HS_TC_TM_dispense_changes].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[041ad55e7b][OT2_S_v2_15_P300M_P20S_HS_TC_TM_dispense_changes].json index ab7e1ecff2e..d5de47a11de 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[041ad55e7b][OT2_S_v2_15_P300M_P20S_HS_TC_TM_dispense_changes].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[041ad55e7b][OT2_S_v2_15_P300M_P20S_HS_TC_TM_dispense_changes].json @@ -17,41 +17,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Let there be light! True 🌠🌠🌠", - "legacyCommandType": "command.COMMENT" + "message": "Let there be light! True 🌠🌠🌠" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Is the door is closed? True 🚪🚪🚪", - "legacyCommandType": "command.COMMENT" + "message": "Is the door is closed? True 🚪🚪🚪" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Is this a simulation? True 🔮🔮🔮", - "legacyCommandType": "command.COMMENT" + "message": "Is this a simulation? True 🔮🔮🔮" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Running against API Version: 2.15", - "legacyCommandType": "command.COMMENT" + "message": "Running against API Version: 2.15" }, "result": {}, "status": "succeeded" diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[0affe60373][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_maximum].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[0affe60373][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_maximum].json index 702aacc9f50..4202605a598 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[0affe60373][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_maximum].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[0affe60373][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_maximum].json @@ -21,7 +21,7 @@ "errorInfo": { "args": "(\"Maximum is type 'str', but must be of parameter type 'int'\",)", "class": "ParameterDefinitionError", - "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_maximum.py\", line 104, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 61, in add_int\n parameter = parameter_definition.create_int_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 199, in create_int_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 94, in __init__\n validation.validate_options(default, minimum, maximum, choices, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 266, in validate_options\n _validate_min_and_max(minimum, maximum, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 218, in _validate_min_and_max\n raise ParameterDefinitionError(\n" + "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_maximum.py\", line 104, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 61, in add_int\n parameter = parameter_definition.create_int_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 200, in create_int_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 95, in __init__\n validation.validate_options(default, minimum, maximum, choices, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 266, in validate_options\n _validate_min_and_max(minimum, maximum, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 218, in _validate_min_and_max\n raise ParameterDefinitionError(\n" }, "errorType": "PythonException", "isDefined": false, diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[0c4ae179bb][OT2_S_v2_15_P300M_P20S_HS_TC_TM_SmokeTestV3].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[0c4ae179bb][OT2_S_v2_15_P300M_P20S_HS_TC_TM_SmokeTestV3].json index 182728fb2fd..4fddd462be2 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[0c4ae179bb][OT2_S_v2_15_P300M_P20S_HS_TC_TM_SmokeTestV3].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[0c4ae179bb][OT2_S_v2_15_P300M_P20S_HS_TC_TM_SmokeTestV3].json @@ -17,41 +17,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Let there be light! True 🌠🌠🌠", - "legacyCommandType": "command.COMMENT" + "message": "Let there be light! True 🌠🌠🌠" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Is the door is closed? True 🚪🚪🚪", - "legacyCommandType": "command.COMMENT" + "message": "Is the door is closed? True 🚪🚪🚪" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Is this a simulation? True 🔮🔮🔮", - "legacyCommandType": "command.COMMENT" + "message": "Is this a simulation? True 🔮🔮🔮" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Running against API Version: 2.15", - "legacyCommandType": "command.COMMENT" + "message": "Running against API Version: 2.15" }, "result": {}, "status": "succeeded" diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[12a2a22254][Flex_S_v2_15_P1000M_P50M_GRIP_HS_MB_TC_TM_IlluminaDNAEnrichment].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[12a2a22254][Flex_S_v2_15_P1000M_P50M_GRIP_HS_MB_TC_TM_IlluminaDNAEnrichment].json index c6a3aa93e8f..022dd90e812 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[12a2a22254][Flex_S_v2_15_P1000M_P50M_GRIP_HS_MB_TC_TM_IlluminaDNAEnrichment].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[12a2a22254][Flex_S_v2_15_P1000M_P50M_GRIP_HS_MB_TC_TM_IlluminaDNAEnrichment].json @@ -8,11 +8,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "THIS IS A DRY RUN", - "legacyCommandType": "command.COMMENT" + "message": "THIS IS A DRY RUN" }, "result": {}, "status": "succeeded" @@ -9466,71 +9465,64 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Quick Vol Pool", - "legacyCommandType": "command.COMMENT" + "message": "--> Quick Vol Pool" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Capture", - "legacyCommandType": "command.COMMENT" + "message": "--> Capture" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding NHB2", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding NHB2" }, "result": {}, "status": "succeeded" @@ -9638,11 +9630,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding Panel", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding Panel" }, "result": {}, "status": "succeeded" @@ -9750,11 +9741,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding EHB2", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding EHB2" }, "result": {}, "status": "succeeded" @@ -9938,11 +9928,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Hybridize on Deck", - "legacyCommandType": "command.COMMENT" + "message": "Hybridize on Deck" }, "result": {}, "status": "succeeded" @@ -9962,11 +9951,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Heating EEW", - "legacyCommandType": "command.COMMENT" + "message": "--> Heating EEW" }, "result": {}, "status": "succeeded" @@ -10230,11 +10218,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Transfer Hybridization", - "legacyCommandType": "command.COMMENT" + "message": "--> Transfer Hybridization" }, "result": {}, "status": "succeeded" @@ -10373,11 +10360,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ADDING SMB", - "legacyCommandType": "command.COMMENT" + "message": "--> ADDING SMB" }, "result": {}, "status": "succeeded" @@ -11325,41 +11311,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> WASH", - "legacyCommandType": "command.COMMENT" + "message": "--> WASH" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Remove SUPERNATANT", - "legacyCommandType": "command.COMMENT" + "message": "--> Remove SUPERNATANT" }, "result": {}, "status": "succeeded" @@ -11662,21 +11644,19 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Repeating 3 washes", - "legacyCommandType": "command.COMMENT" + "message": "--> Repeating 3 washes" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding EEW", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding EEW" }, "result": {}, "status": "succeeded" @@ -11863,11 +11843,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Supernatant" }, "result": {}, "status": "succeeded" @@ -12177,11 +12156,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding EEW", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding EEW" }, "result": {}, "status": "succeeded" @@ -12368,11 +12346,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Supernatant" }, "result": {}, "status": "succeeded" @@ -12682,11 +12659,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding EEW", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding EEW" }, "result": {}, "status": "succeeded" @@ -12873,11 +12849,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Supernatant" }, "result": {}, "status": "succeeded" @@ -13187,11 +13162,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding EEW", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding EEW" }, "result": {}, "status": "succeeded" @@ -13317,11 +13291,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Transfer Hybridization", - "legacyCommandType": "command.COMMENT" + "message": "--> Transfer Hybridization" }, "result": {}, "status": "succeeded" @@ -13498,11 +13471,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Supernatant" }, "result": {}, "status": "succeeded" @@ -13776,11 +13748,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Residual", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Residual" }, "result": {}, "status": "succeeded" @@ -13993,41 +13964,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ELUTE", - "legacyCommandType": "command.COMMENT" + "message": "--> ELUTE" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding EE1", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding EE1" }, "result": {}, "status": "succeeded" @@ -14241,11 +14208,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Transfer Elution", - "legacyCommandType": "command.COMMENT" + "message": "--> Transfer Elution" }, "result": {}, "status": "succeeded" @@ -14377,11 +14343,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding ET2", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding ET2" }, "result": {}, "status": "succeeded" @@ -14565,41 +14530,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> AMPLIFICATION", - "legacyCommandType": "command.COMMENT" + "message": "--> AMPLIFICATION" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding PPC", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding PPC" }, "result": {}, "status": "succeeded" @@ -14707,11 +14668,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding EPM", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding EPM" }, "result": {}, "status": "succeeded" @@ -14902,31 +14862,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Cleanup", - "legacyCommandType": "command.COMMENT" + "message": "--> Cleanup" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -14968,11 +14925,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Transfer Elution", - "legacyCommandType": "command.COMMENT" + "message": "--> Transfer Elution" }, "result": {}, "status": "succeeded" @@ -15104,11 +15060,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ADDING AMPure (0.8x)", - "legacyCommandType": "command.COMMENT" + "message": "--> ADDING AMPure (0.8x)" }, "result": {}, "status": "succeeded" @@ -15755,11 +15710,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Supernatant" }, "result": {}, "status": "succeeded" @@ -16055,11 +16009,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ETOH Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> ETOH Wash" }, "result": {}, "status": "succeeded" @@ -16368,11 +16321,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Remove ETOH Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> Remove ETOH Wash" }, "result": {}, "status": "succeeded" @@ -16668,11 +16620,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ETOH Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> ETOH Wash" }, "result": {}, "status": "succeeded" @@ -16981,11 +16932,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Remove ETOH Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> Remove ETOH Wash" }, "result": {}, "status": "succeeded" @@ -17281,11 +17231,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Residual ETOH", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Residual ETOH" }, "result": {}, "status": "succeeded" @@ -17534,11 +17483,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding RSB", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding RSB" }, "result": {}, "status": "succeeded" @@ -18205,11 +18153,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Transferring Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Transferring Supernatant" }, "result": {}, "status": "succeeded" diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[1960aa7a4c][Flex_S_v2_15_P1000M_P50M_GRIP_HS_MB_TC_TM_IlluminaDNAEnrichmentv4].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[1960aa7a4c][Flex_S_v2_15_P1000M_P50M_GRIP_HS_MB_TC_TM_IlluminaDNAEnrichmentv4].json index 5e09ff0c2bf..1596ca09eae 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[1960aa7a4c][Flex_S_v2_15_P1000M_P50M_GRIP_HS_MB_TC_TM_IlluminaDNAEnrichmentv4].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[1960aa7a4c][Flex_S_v2_15_P1000M_P50M_GRIP_HS_MB_TC_TM_IlluminaDNAEnrichmentv4].json @@ -8,31 +8,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "THIS IS A ABR RUN WITH 3 REPEATS", - "legacyCommandType": "command.COMMENT" + "message": "THIS IS A ABR RUN WITH 3 REPEATS" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "THIS IS A DRY RUN", - "legacyCommandType": "command.COMMENT" + "message": "THIS IS A DRY RUN" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "USED TIPS WILL BE RE-RACKED", - "legacyCommandType": "command.COMMENT" + "message": "USED TIPS WILL BE RE-RACKED" }, "result": {}, "status": "succeeded" @@ -11735,41 +11732,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Capture", - "legacyCommandType": "command.COMMENT" + "message": "--> Capture" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Transfer Hybridization", - "legacyCommandType": "command.COMMENT" + "message": "--> Transfer Hybridization" }, "result": {}, "status": "succeeded" @@ -12160,11 +12153,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ADDING SMB", - "legacyCommandType": "command.COMMENT" + "message": "--> ADDING SMB" }, "result": {}, "status": "succeeded" @@ -14132,41 +14124,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> WASH", - "legacyCommandType": "command.COMMENT" + "message": "--> WASH" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Remove SUPERNATANT", - "legacyCommandType": "command.COMMENT" + "message": "--> Remove SUPERNATANT" }, "result": {}, "status": "succeeded" @@ -15063,21 +15051,19 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Repeating 3 washes", - "legacyCommandType": "command.COMMENT" + "message": "--> Repeating 3 washes" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding EEW", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding EEW" }, "result": {}, "status": "succeeded" @@ -15461,11 +15447,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Supernatant" }, "result": {}, "status": "succeeded" @@ -16311,11 +16296,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding EEW", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding EEW" }, "result": {}, "status": "succeeded" @@ -16699,11 +16683,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Supernatant" }, "result": {}, "status": "succeeded" @@ -17549,11 +17532,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding EEW", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding EEW" }, "result": {}, "status": "succeeded" @@ -17937,11 +17919,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Supernatant" }, "result": {}, "status": "succeeded" @@ -18787,11 +18768,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding EEW", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding EEW" }, "result": {}, "status": "succeeded" @@ -19121,11 +19101,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Transfer Hybridization", - "legacyCommandType": "command.COMMENT" + "message": "--> Transfer Hybridization" }, "result": {}, "status": "succeeded" @@ -19547,11 +19526,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Supernatant" }, "result": {}, "status": "succeeded" @@ -20361,11 +20339,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Residual", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Residual" }, "result": {}, "status": "succeeded" @@ -20992,41 +20969,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ELUTE", - "legacyCommandType": "command.COMMENT" + "message": "--> ELUTE" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding Elute", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding Elute" }, "result": {}, "status": "succeeded" @@ -21446,11 +21419,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Transfer Elution", - "legacyCommandType": "command.COMMENT" + "message": "--> Transfer Elution" }, "result": {}, "status": "succeeded" @@ -21834,11 +21806,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding ET2", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding ET2" }, "result": {}, "status": "succeeded" @@ -22378,41 +22349,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> AMPLIFICATION", - "legacyCommandType": "command.COMMENT" + "message": "--> AMPLIFICATION" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding PPC", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding PPC" }, "result": {}, "status": "succeeded" @@ -22724,11 +22691,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding EPM", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding EPM" }, "result": {}, "status": "succeeded" @@ -23268,31 +23234,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Cleanup", - "legacyCommandType": "command.COMMENT" + "message": "--> Cleanup" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -23334,11 +23297,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Transfer Elution", - "legacyCommandType": "command.COMMENT" + "message": "--> Transfer Elution" }, "result": {}, "status": "succeeded" @@ -23722,11 +23684,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ADDING AMPure (0.8x)", - "legacyCommandType": "command.COMMENT" + "message": "--> ADDING AMPure (0.8x)" }, "result": {}, "status": "succeeded" @@ -25531,11 +25492,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Supernatant" }, "result": {}, "status": "succeeded" @@ -26411,11 +26371,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ETOH Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> ETOH Wash" }, "result": {}, "status": "succeeded" @@ -27330,11 +27289,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Remove ETOH Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> Remove ETOH Wash" }, "result": {}, "status": "succeeded" @@ -28210,11 +28168,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ETOH Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> ETOH Wash" }, "result": {}, "status": "succeeded" @@ -29129,11 +29086,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Remove ETOH Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> Remove ETOH Wash" }, "result": {}, "status": "succeeded" @@ -30009,11 +29965,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Residual ETOH", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Residual ETOH" }, "result": {}, "status": "succeeded" @@ -30676,11 +30631,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding RSB", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding RSB" }, "result": {}, "status": "succeeded" @@ -32518,11 +32472,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Transferring Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Transferring Supernatant" }, "result": {}, "status": "succeeded" @@ -32906,31 +32859,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Resetting Run", - "legacyCommandType": "command.COMMENT" + "message": "--> Resetting Run" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -36432,41 +36382,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Capture", - "legacyCommandType": "command.COMMENT" + "message": "--> Capture" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Transfer Hybridization", - "legacyCommandType": "command.COMMENT" + "message": "--> Transfer Hybridization" }, "result": {}, "status": "succeeded" @@ -36857,11 +36803,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ADDING SMB", - "legacyCommandType": "command.COMMENT" + "message": "--> ADDING SMB" }, "result": {}, "status": "succeeded" @@ -38829,41 +38774,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> WASH", - "legacyCommandType": "command.COMMENT" + "message": "--> WASH" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Remove SUPERNATANT", - "legacyCommandType": "command.COMMENT" + "message": "--> Remove SUPERNATANT" }, "result": {}, "status": "succeeded" @@ -39760,21 +39701,19 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Repeating 3 washes", - "legacyCommandType": "command.COMMENT" + "message": "--> Repeating 3 washes" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding EEW", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding EEW" }, "result": {}, "status": "succeeded" @@ -40158,11 +40097,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Supernatant" }, "result": {}, "status": "succeeded" @@ -41008,11 +40946,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding EEW", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding EEW" }, "result": {}, "status": "succeeded" @@ -41396,11 +41333,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Supernatant" }, "result": {}, "status": "succeeded" @@ -42246,11 +42182,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding EEW", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding EEW" }, "result": {}, "status": "succeeded" @@ -42634,11 +42569,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Supernatant" }, "result": {}, "status": "succeeded" @@ -43484,11 +43418,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding EEW", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding EEW" }, "result": {}, "status": "succeeded" @@ -43818,11 +43751,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Transfer Hybridization", - "legacyCommandType": "command.COMMENT" + "message": "--> Transfer Hybridization" }, "result": {}, "status": "succeeded" @@ -44244,11 +44176,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Supernatant" }, "result": {}, "status": "succeeded" @@ -45058,11 +44989,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Residual", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Residual" }, "result": {}, "status": "succeeded" @@ -45689,41 +45619,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ELUTE", - "legacyCommandType": "command.COMMENT" + "message": "--> ELUTE" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding Elute", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding Elute" }, "result": {}, "status": "succeeded" @@ -46143,11 +46069,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Transfer Elution", - "legacyCommandType": "command.COMMENT" + "message": "--> Transfer Elution" }, "result": {}, "status": "succeeded" @@ -46531,11 +46456,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding ET2", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding ET2" }, "result": {}, "status": "succeeded" @@ -47075,41 +46999,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> AMPLIFICATION", - "legacyCommandType": "command.COMMENT" + "message": "--> AMPLIFICATION" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding PPC", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding PPC" }, "result": {}, "status": "succeeded" @@ -47421,11 +47341,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding EPM", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding EPM" }, "result": {}, "status": "succeeded" @@ -47965,31 +47884,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Cleanup", - "legacyCommandType": "command.COMMENT" + "message": "--> Cleanup" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -48031,11 +47947,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Transfer Elution", - "legacyCommandType": "command.COMMENT" + "message": "--> Transfer Elution" }, "result": {}, "status": "succeeded" @@ -48419,11 +48334,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ADDING AMPure (0.8x)", - "legacyCommandType": "command.COMMENT" + "message": "--> ADDING AMPure (0.8x)" }, "result": {}, "status": "succeeded" @@ -50228,11 +50142,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Supernatant" }, "result": {}, "status": "succeeded" @@ -51108,11 +51021,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ETOH Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> ETOH Wash" }, "result": {}, "status": "succeeded" @@ -52027,11 +51939,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Remove ETOH Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> Remove ETOH Wash" }, "result": {}, "status": "succeeded" @@ -52907,11 +52818,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ETOH Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> ETOH Wash" }, "result": {}, "status": "succeeded" @@ -53826,11 +53736,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Remove ETOH Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> Remove ETOH Wash" }, "result": {}, "status": "succeeded" @@ -54706,11 +54615,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Residual ETOH", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Residual ETOH" }, "result": {}, "status": "succeeded" @@ -55373,11 +55281,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding RSB", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding RSB" }, "result": {}, "status": "succeeded" @@ -57215,11 +57122,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Transferring Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Transferring Supernatant" }, "result": {}, "status": "succeeded" @@ -57603,31 +57509,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Resetting Run", - "legacyCommandType": "command.COMMENT" + "message": "--> Resetting Run" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -61129,41 +61032,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Capture", - "legacyCommandType": "command.COMMENT" + "message": "--> Capture" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Transfer Hybridization", - "legacyCommandType": "command.COMMENT" + "message": "--> Transfer Hybridization" }, "result": {}, "status": "succeeded" @@ -61554,11 +61453,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ADDING SMB", - "legacyCommandType": "command.COMMENT" + "message": "--> ADDING SMB" }, "result": {}, "status": "succeeded" @@ -63526,41 +63424,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> WASH", - "legacyCommandType": "command.COMMENT" + "message": "--> WASH" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Remove SUPERNATANT", - "legacyCommandType": "command.COMMENT" + "message": "--> Remove SUPERNATANT" }, "result": {}, "status": "succeeded" @@ -64457,21 +64351,19 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Repeating 3 washes", - "legacyCommandType": "command.COMMENT" + "message": "--> Repeating 3 washes" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding EEW", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding EEW" }, "result": {}, "status": "succeeded" @@ -64855,11 +64747,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Supernatant" }, "result": {}, "status": "succeeded" @@ -65705,11 +65596,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding EEW", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding EEW" }, "result": {}, "status": "succeeded" @@ -66093,11 +65983,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Supernatant" }, "result": {}, "status": "succeeded" @@ -66943,11 +66832,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding EEW", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding EEW" }, "result": {}, "status": "succeeded" @@ -67331,11 +67219,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Supernatant" }, "result": {}, "status": "succeeded" @@ -68181,11 +68068,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding EEW", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding EEW" }, "result": {}, "status": "succeeded" @@ -68515,11 +68401,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Transfer Hybridization", - "legacyCommandType": "command.COMMENT" + "message": "--> Transfer Hybridization" }, "result": {}, "status": "succeeded" @@ -68941,11 +68826,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Supernatant" }, "result": {}, "status": "succeeded" @@ -69755,11 +69639,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Residual", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Residual" }, "result": {}, "status": "succeeded" @@ -70386,41 +70269,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ELUTE", - "legacyCommandType": "command.COMMENT" + "message": "--> ELUTE" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding Elute", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding Elute" }, "result": {}, "status": "succeeded" @@ -70840,11 +70719,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Transfer Elution", - "legacyCommandType": "command.COMMENT" + "message": "--> Transfer Elution" }, "result": {}, "status": "succeeded" @@ -71228,11 +71106,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding ET2", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding ET2" }, "result": {}, "status": "succeeded" @@ -71772,41 +71649,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> AMPLIFICATION", - "legacyCommandType": "command.COMMENT" + "message": "--> AMPLIFICATION" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding PPC", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding PPC" }, "result": {}, "status": "succeeded" @@ -72118,11 +71991,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding EPM", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding EPM" }, "result": {}, "status": "succeeded" @@ -72662,31 +72534,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Cleanup", - "legacyCommandType": "command.COMMENT" + "message": "--> Cleanup" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -72728,11 +72597,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Transfer Elution", - "legacyCommandType": "command.COMMENT" + "message": "--> Transfer Elution" }, "result": {}, "status": "succeeded" @@ -73116,11 +72984,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ADDING AMPure (0.8x)", - "legacyCommandType": "command.COMMENT" + "message": "--> ADDING AMPure (0.8x)" }, "result": {}, "status": "succeeded" @@ -74925,11 +74792,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Supernatant" }, "result": {}, "status": "succeeded" @@ -75805,11 +75671,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ETOH Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> ETOH Wash" }, "result": {}, "status": "succeeded" @@ -76724,11 +76589,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Remove ETOH Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> Remove ETOH Wash" }, "result": {}, "status": "succeeded" @@ -77604,11 +77468,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ETOH Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> ETOH Wash" }, "result": {}, "status": "succeeded" @@ -78523,11 +78386,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Remove ETOH Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> Remove ETOH Wash" }, "result": {}, "status": "succeeded" @@ -79403,11 +79265,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Residual ETOH", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Residual ETOH" }, "result": {}, "status": "succeeded" @@ -80070,11 +79931,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding RSB", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding RSB" }, "result": {}, "status": "succeeded" @@ -81912,11 +81772,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Transferring Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Transferring Supernatant" }, "result": {}, "status": "succeeded" @@ -82300,31 +82159,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Resetting Run", - "legacyCommandType": "command.COMMENT" + "message": "--> Resetting Run" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[19ffa9c839][OT2_X_v2_16_None_None_HS_HeaterShakerConflictWithTrashBin2].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[19ffa9c839][OT2_X_v2_16_None_None_HS_HeaterShakerConflictWithTrashBin2].json index cf8f4d6a6fb..3d4f3d177ee 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[19ffa9c839][OT2_X_v2_16_None_None_HS_HeaterShakerConflictWithTrashBin2].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[19ffa9c839][OT2_X_v2_16_None_None_HS_HeaterShakerConflictWithTrashBin2].json @@ -479,7 +479,7 @@ "errorInfo": { "args": "('trash bin in slot 12 prevents heaterShakerModuleV1 from using slot 9.',)", "class": "DeckConflictError", - "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 147, in exec_run\n exec(\"run(__context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"OT2_X_v2_16_None_None_HS_HeaterShakerConflictWithTrashBin2.py\", line 11, in run\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/api_support/util.py\", line 383, in _check_version_wrapper\n return decorated_obj(*args, **kwargs)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/protocol_context.py\", line 826, in load_module\n module_core = self._core.load_module(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/core/engine/protocol.py\", line 424, in load_module\n deck_conflict.check(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/core/engine/deck_conflict.py\", line 203, in check\n wrapped_deck_conflict.check(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/motion_planning/deck_conflict.py\", line 210, in check\n raise DeckConflictError(\n" + "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 147, in exec_run\n exec(\"run(__context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"OT2_X_v2_16_None_None_HS_HeaterShakerConflictWithTrashBin2.py\", line 11, in run\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/api_support/util.py\", line 383, in _check_version_wrapper\n return decorated_obj(*args, **kwargs)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/protocol_context.py\", line 826, in load_module\n module_core = self._core.load_module(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/core/engine/protocol.py\", line 433, in load_module\n deck_conflict.check(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/core/engine/deck_conflict.py\", line 203, in check\n wrapped_deck_conflict.check(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/motion_planning/deck_conflict.py\", line 210, in check\n raise DeckConflictError(\n" }, "errorType": "PythonException", "isDefined": false, diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[1e5825a070][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_minimum].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[1e5825a070][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_minimum].json index 0432e40537e..99db011b4f8 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[1e5825a070][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_minimum].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[1e5825a070][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_minimum].json @@ -21,7 +21,7 @@ "errorInfo": { "args": "(\"Minimum is type 'str', but must be of parameter type 'int'\",)", "class": "ParameterDefinitionError", - "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_minimum.py\", line 95, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 61, in add_int\n parameter = parameter_definition.create_int_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 199, in create_int_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 94, in __init__\n validation.validate_options(default, minimum, maximum, choices, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 266, in validate_options\n _validate_min_and_max(minimum, maximum, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 213, in _validate_min_and_max\n raise ParameterDefinitionError(\n" + "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_minimum.py\", line 95, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 61, in add_int\n parameter = parameter_definition.create_int_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 200, in create_int_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 95, in __init__\n validation.validate_options(default, minimum, maximum, choices, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 266, in validate_options\n _validate_min_and_max(minimum, maximum, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 213, in _validate_min_and_max\n raise ParameterDefinitionError(\n" }, "errorType": "PythonException", "isDefined": false, diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[33db294a9b][Flex_X_v2_18_NO_PIPETTES_DescriptionTooLongRTP].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[33db294a9b][Flex_X_v2_18_NO_PIPETTES_DescriptionTooLongRTP].json index a61a4a011ff..2051bb287bc 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[33db294a9b][Flex_X_v2_18_NO_PIPETTES_DescriptionTooLongRTP].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[33db294a9b][Flex_X_v2_18_NO_PIPETTES_DescriptionTooLongRTP].json @@ -8,11 +8,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable dilutions has value 1", - "legacyCommandType": "command.COMMENT" + "message": "variable dilutions has value 1" }, "result": {}, "status": "succeeded" diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[38b5298c77][Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultOutOfRangeRTP_Override_default_less_than_minimum].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[38b5298c77][Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultOutOfRangeRTP_Override_default_less_than_minimum].json index 03560be04e5..607de8908f1 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[38b5298c77][Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultOutOfRangeRTP_Override_default_less_than_minimum].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[38b5298c77][Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultOutOfRangeRTP_Override_default_less_than_minimum].json @@ -21,7 +21,7 @@ "errorInfo": { "args": "('Parameter must be between 1 and 3 inclusive.',)", "class": "ParameterValueError", - "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultOutOfRangeRTP_Override_default_less_than_minimum.py\", line 32, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 61, in add_int\n parameter = parameter_definition.create_int_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 199, in create_int_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 105, in __init__\n self.value: PrimitiveAllowedTypes = default\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 125, in value\n raise ParameterValueError(\n" + "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultOutOfRangeRTP_Override_default_less_than_minimum.py\", line 32, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 61, in add_int\n parameter = parameter_definition.create_int_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 200, in create_int_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 106, in __init__\n self.value: PrimitiveAllowedTypes = default\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 126, in value\n raise ParameterValueError(\n" }, "errorType": "PythonException", "isDefined": false, diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[4458220422][OT2_S_v2_18_NO_PIPETTES_GoldenRTP_OT2].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[4458220422][OT2_S_v2_18_NO_PIPETTES_GoldenRTP_OT2].json index 11c189fdd9e..e53372a92ad 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[4458220422][OT2_S_v2_18_NO_PIPETTES_GoldenRTP_OT2].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[4458220422][OT2_S_v2_18_NO_PIPETTES_GoldenRTP_OT2].json @@ -8,191 +8,172 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable min_max_all_fields has value 6", - "legacyCommandType": "command.COMMENT" + "message": "variable min_max_all_fields has value 6" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable int_min_max_without_unit has value 1", - "legacyCommandType": "command.COMMENT" + "message": "variable int_min_max_without_unit has value 1" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable int_min_max_without_description has value 1", - "legacyCommandType": "command.COMMENT" + "message": "variable int_min_max_without_description has value 1" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable int_min_max_without_unit_and_description has value 1", - "legacyCommandType": "command.COMMENT" + "message": "variable int_min_max_without_unit_and_description has value 1" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable int_choices_all_fields has value 20", - "legacyCommandType": "command.COMMENT" + "message": "variable int_choices_all_fields has value 20" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable int_choice_no_unit has value 6", - "legacyCommandType": "command.COMMENT" + "message": "variable int_choice_no_unit has value 6" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable int_choice_no_unit_desc has value 10", - "legacyCommandType": "command.COMMENT" + "message": "variable int_choice_no_unit_desc has value 10" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable float_min_max_all_fields has value 30.0", - "legacyCommandType": "command.COMMENT" + "message": "variable float_min_max_all_fields has value 30.0" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable float_min_max_no_unit has value 1.8", - "legacyCommandType": "command.COMMENT" + "message": "variable float_min_max_no_unit has value 1.8" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable float_min_max_no_unit_or_desc has value 1.8", - "legacyCommandType": "command.COMMENT" + "message": "variable float_min_max_no_unit_or_desc has value 1.8" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable float_choices_all_fields has value 20.0", - "legacyCommandType": "command.COMMENT" + "message": "variable float_choices_all_fields has value 20.0" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable float_choices_no_unit has value 10.0", - "legacyCommandType": "command.COMMENT" + "message": "variable float_choices_no_unit has value 10.0" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable float_choices_no_description has value 20.0", - "legacyCommandType": "command.COMMENT" + "message": "variable float_choices_no_description has value 20.0" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable float_choices_no_unit_or_desc has value 20.0", - "legacyCommandType": "command.COMMENT" + "message": "variable float_choices_no_unit_or_desc has value 20.0" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable bool_all_fields has value False", - "legacyCommandType": "command.COMMENT" + "message": "variable bool_all_fields has value False" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable bool_no_desc has value False", - "legacyCommandType": "command.COMMENT" + "message": "variable bool_no_desc has value False" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable str_choices_all_fields has value flex_1channel_50", - "legacyCommandType": "command.COMMENT" + "message": "variable str_choices_all_fields has value flex_1channel_50" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable str_choices_all_many_fields has value E", - "legacyCommandType": "command.COMMENT" + "message": "variable str_choices_all_many_fields has value E" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable str_choices_no_desc has value flex_1channel_50", - "legacyCommandType": "command.COMMENT" + "message": "variable str_choices_no_desc has value flex_1channel_50" }, "result": {}, "status": "succeeded" diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[4a82419f1f][OT2_S_v2_16_P300M_P20S_HS_TC_TM_SmokeTestV3].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[4a82419f1f][OT2_S_v2_16_P300M_P20S_HS_TC_TM_SmokeTestV3].json index 13fce2fceb6..34cb70d0612 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[4a82419f1f][OT2_S_v2_16_P300M_P20S_HS_TC_TM_SmokeTestV3].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[4a82419f1f][OT2_S_v2_16_P300M_P20S_HS_TC_TM_SmokeTestV3].json @@ -17,41 +17,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Let there be light! True 🌠🌠🌠", - "legacyCommandType": "command.COMMENT" + "message": "Let there be light! True 🌠🌠🌠" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Is the door is closed? True 🚪🚪🚪", - "legacyCommandType": "command.COMMENT" + "message": "Is the door is closed? True 🚪🚪🚪" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Is this a simulation? True 🔮🔮🔮", - "legacyCommandType": "command.COMMENT" + "message": "Is this a simulation? True 🔮🔮🔮" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Running against API Version: 2.16", - "legacyCommandType": "command.COMMENT" + "message": "Running against API Version: 2.16" }, "result": {}, "status": "succeeded" diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[4b17883f74][OT2_S_v2_17_P300M_P20S_HS_TC_TM_dispense_changes].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[4b17883f74][OT2_S_v2_17_P300M_P20S_HS_TC_TM_dispense_changes].json index ae2c0ebc990..ecec5db54eb 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[4b17883f74][OT2_S_v2_17_P300M_P20S_HS_TC_TM_dispense_changes].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[4b17883f74][OT2_S_v2_17_P300M_P20S_HS_TC_TM_dispense_changes].json @@ -17,41 +17,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Let there be light! True 🌠🌠🌠", - "legacyCommandType": "command.COMMENT" + "message": "Let there be light! True 🌠🌠🌠" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Is the door is closed? True 🚪🚪🚪", - "legacyCommandType": "command.COMMENT" + "message": "Is the door is closed? True 🚪🚪🚪" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Is this a simulation? True 🔮🔮🔮", - "legacyCommandType": "command.COMMENT" + "message": "Is this a simulation? True 🔮🔮🔮" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Running against API Version: 2.17", - "legacyCommandType": "command.COMMENT" + "message": "Running against API Version: 2.17" }, "result": {}, "status": "succeeded" diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[4fadc166c0][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_variable_name].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[4fadc166c0][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_variable_name].json index d888aa97b4b..bb7fc3be79c 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[4fadc166c0][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_variable_name].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[4fadc166c0][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_variable_name].json @@ -21,7 +21,7 @@ "errorInfo": { "args": "('Variable name must be a string.',)", "class": "ParameterNameError", - "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_variable_name.py\", line 39, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 98, in add_float\n parameter = parameter_definition.create_float_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 223, in create_float_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 78, in __init__\n self._variable_name = validation.ensure_variable_name(variable_name)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 46, in ensure_variable_name\n raise ParameterNameError(\"Variable name must be a string.\")\n" + "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_variable_name.py\", line 39, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 98, in add_float\n parameter = parameter_definition.create_float_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 224, in create_float_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 79, in __init__\n self._variable_name = validation.ensure_variable_name(variable_name)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 46, in ensure_variable_name\n raise ParameterNameError(\"Variable name must be a string.\")\n" }, "errorType": "PythonException", "isDefined": false, diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[51a761307d][Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultOutOfRangeRTP_Override_default_greater_than_maximum].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[51a761307d][Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultOutOfRangeRTP_Override_default_greater_than_maximum].json index 021c4b74a9b..356bebe4620 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[51a761307d][Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultOutOfRangeRTP_Override_default_greater_than_maximum].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[51a761307d][Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultOutOfRangeRTP_Override_default_greater_than_maximum].json @@ -21,7 +21,7 @@ "errorInfo": { "args": "('Parameter must be between 1 and 3 inclusive.',)", "class": "ParameterValueError", - "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultOutOfRangeRTP_Override_default_greater_than_maximum.py\", line 23, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 61, in add_int\n parameter = parameter_definition.create_int_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 199, in create_int_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 105, in __init__\n self.value: PrimitiveAllowedTypes = default\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 125, in value\n raise ParameterValueError(\n" + "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultOutOfRangeRTP_Override_default_greater_than_maximum.py\", line 23, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 61, in add_int\n parameter = parameter_definition.create_int_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 200, in create_int_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 106, in __init__\n self.value: PrimitiveAllowedTypes = default\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 126, in value\n raise ParameterValueError(\n" }, "errorType": "PythonException", "isDefined": false, diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[60c1d39463][Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultChoiceNoMatchChoice_Override_int_default_no_matching_choices].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[60c1d39463][Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultChoiceNoMatchChoice_Override_int_default_no_matching_choices].json index dcec334d884..bcb4f9580ab 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[60c1d39463][Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultChoiceNoMatchChoice_Override_int_default_no_matching_choices].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[60c1d39463][Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultChoiceNoMatchChoice_Override_int_default_no_matching_choices].json @@ -21,7 +21,7 @@ "errorInfo": { "args": "('Parameter must be set to one of the allowed values of {9, 20, 15}.',)", "class": "ParameterValueError", - "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultChoiceNoMatchChoice_Override_int_default_no_matching_choices.py\", line 24, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 61, in add_int\n parameter = parameter_definition.create_int_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 199, in create_int_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 105, in __init__\n self.value: PrimitiveAllowedTypes = default\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 116, in value\n raise ParameterValueError(\n" + "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultChoiceNoMatchChoice_Override_int_default_no_matching_choices.py\", line 24, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 61, in add_int\n parameter = parameter_definition.create_int_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 200, in create_int_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 106, in __init__\n self.value: PrimitiveAllowedTypes = default\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 117, in value\n raise ParameterValueError(\n" }, "errorType": "PythonException", "isDefined": false, diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[61619d5498][Flex_S_v2_18_NO_PIPETTES_GoldenRTP].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[61619d5498][Flex_S_v2_18_NO_PIPETTES_GoldenRTP].json index c5df0de2115..cfa3a98dd49 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[61619d5498][Flex_S_v2_18_NO_PIPETTES_GoldenRTP].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[61619d5498][Flex_S_v2_18_NO_PIPETTES_GoldenRTP].json @@ -8,191 +8,172 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable min_max_all_fields has value 6", - "legacyCommandType": "command.COMMENT" + "message": "variable min_max_all_fields has value 6" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable int_min_max_without_unit has value 1", - "legacyCommandType": "command.COMMENT" + "message": "variable int_min_max_without_unit has value 1" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable int_min_max_without_description has value 1", - "legacyCommandType": "command.COMMENT" + "message": "variable int_min_max_without_description has value 1" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable int_min_max_without_unit_and_description has value 1", - "legacyCommandType": "command.COMMENT" + "message": "variable int_min_max_without_unit_and_description has value 1" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable int_choices_all_fields has value 20", - "legacyCommandType": "command.COMMENT" + "message": "variable int_choices_all_fields has value 20" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable int_choice_no_unit has value 6", - "legacyCommandType": "command.COMMENT" + "message": "variable int_choice_no_unit has value 6" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable int_choice_no_unit_desc has value 10", - "legacyCommandType": "command.COMMENT" + "message": "variable int_choice_no_unit_desc has value 10" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable float_min_max_all_fields has value 30.0", - "legacyCommandType": "command.COMMENT" + "message": "variable float_min_max_all_fields has value 30.0" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable float_min_max_no_unit has value 1.8", - "legacyCommandType": "command.COMMENT" + "message": "variable float_min_max_no_unit has value 1.8" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable float_min_max_no_unit_or_desc has value 1.8", - "legacyCommandType": "command.COMMENT" + "message": "variable float_min_max_no_unit_or_desc has value 1.8" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable float_choices_all_fields has value 20.0", - "legacyCommandType": "command.COMMENT" + "message": "variable float_choices_all_fields has value 20.0" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable float_choices_no_unit has value 10.0", - "legacyCommandType": "command.COMMENT" + "message": "variable float_choices_no_unit has value 10.0" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable float_choices_no_description has value 20.0", - "legacyCommandType": "command.COMMENT" + "message": "variable float_choices_no_description has value 20.0" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable float_choices_no_unit_or_desc has value 20.0", - "legacyCommandType": "command.COMMENT" + "message": "variable float_choices_no_unit_or_desc has value 20.0" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable bool_all_fields has value False", - "legacyCommandType": "command.COMMENT" + "message": "variable bool_all_fields has value False" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable bool_no_desc has value False", - "legacyCommandType": "command.COMMENT" + "message": "variable bool_no_desc has value False" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable str_choices_all_fields has value flex_1channel_50", - "legacyCommandType": "command.COMMENT" + "message": "variable str_choices_all_fields has value flex_1channel_50" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable str_choices_all_many_fields has value E", - "legacyCommandType": "command.COMMENT" + "message": "variable str_choices_all_many_fields has value E" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable str_choices_no_desc has value flex_1channel_50", - "legacyCommandType": "command.COMMENT" + "message": "variable str_choices_no_desc has value flex_1channel_50" }, "result": {}, "status": "succeeded" diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[6ad5590adf][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_unit].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[6ad5590adf][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_unit].json index 49fc1f38b50..f8200ec5515 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[6ad5590adf][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_unit].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[6ad5590adf][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_unit].json @@ -21,7 +21,7 @@ "errorInfo": { "args": "('Unit must be a string and at most 10 characters.',)", "class": "ParameterNameError", - "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_unit.py\", line 113, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 61, in add_int\n parameter = parameter_definition.create_int_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 199, in create_int_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 80, in __init__\n self._unit = validation.ensure_unit_string_length(unit)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 74, in ensure_unit_string_length\n raise ParameterNameError(\n" + "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_unit.py\", line 113, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 61, in add_int\n parameter = parameter_definition.create_int_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 200, in create_int_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 81, in __init__\n self._unit = validation.ensure_unit_string_length(unit)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 74, in ensure_unit_string_length\n raise ParameterNameError(\n" }, "errorType": "PythonException", "isDefined": false, diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[6e5128f107][OT2_X_v2_16_None_None_HS_HeaterShakerConflictWithTrashBin1].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[6e5128f107][OT2_X_v2_16_None_None_HS_HeaterShakerConflictWithTrashBin1].json index 70dedb444f1..de1f09dae46 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[6e5128f107][OT2_X_v2_16_None_None_HS_HeaterShakerConflictWithTrashBin1].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[6e5128f107][OT2_X_v2_16_None_None_HS_HeaterShakerConflictWithTrashBin1].json @@ -479,7 +479,7 @@ "errorInfo": { "args": "('trash bin in slot 12 prevents heaterShakerModuleV1 from using slot 11.',)", "class": "DeckConflictError", - "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 147, in exec_run\n exec(\"run(__context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"OT2_X_v2_16_None_None_HS_HeaterShakerConflictWithTrashBin1.py\", line 11, in run\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/api_support/util.py\", line 383, in _check_version_wrapper\n return decorated_obj(*args, **kwargs)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/protocol_context.py\", line 826, in load_module\n module_core = self._core.load_module(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/core/engine/protocol.py\", line 424, in load_module\n deck_conflict.check(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/core/engine/deck_conflict.py\", line 203, in check\n wrapped_deck_conflict.check(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/motion_planning/deck_conflict.py\", line 223, in check\n raise DeckConflictError(\n" + "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 147, in exec_run\n exec(\"run(__context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"OT2_X_v2_16_None_None_HS_HeaterShakerConflictWithTrashBin1.py\", line 11, in run\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/api_support/util.py\", line 383, in _check_version_wrapper\n return decorated_obj(*args, **kwargs)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/protocol_context.py\", line 826, in load_module\n module_core = self._core.load_module(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/core/engine/protocol.py\", line 433, in load_module\n deck_conflict.check(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/core/engine/deck_conflict.py\", line 203, in check\n wrapped_deck_conflict.check(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/motion_planning/deck_conflict.py\", line 223, in check\n raise DeckConflictError(\n" }, "errorType": "PythonException", "isDefined": false, diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[6e744cbb48][Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultChoiceNoMatchChoice_Override_str_default_no_matching_choices].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[6e744cbb48][Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultChoiceNoMatchChoice_Override_str_default_no_matching_choices].json index 3dc1ab38687..09251fc1ab1 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[6e744cbb48][Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultChoiceNoMatchChoice_Override_str_default_no_matching_choices].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[6e744cbb48][Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultChoiceNoMatchChoice_Override_str_default_no_matching_choices].json @@ -9,19 +9,19 @@ }, "errors": [ { - "detail": "ParameterValueError [line 48]: Parameter must be set to one of the allowed values of {'flex_8channel_50', 'flex_1channel_50'}.", + "detail": "ParameterValueError [line 48]: Parameter must be set to one of the allowed values of {'flex_1channel_50', 'flex_8channel_50'}.", "errorCode": "4000", "errorInfo": {}, "errorType": "ExceptionInProtocolError", "isDefined": false, "wrappedErrors": [ { - "detail": "opentrons.protocols.parameters.types.ParameterValueError: Parameter must be set to one of the allowed values of {'flex_8channel_50', 'flex_1channel_50'}.", + "detail": "opentrons.protocols.parameters.types.ParameterValueError: Parameter must be set to one of the allowed values of {'flex_1channel_50', 'flex_8channel_50'}.", "errorCode": "4000", "errorInfo": { - "args": "(\"Parameter must be set to one of the allowed values of {'flex_8channel_50', 'flex_1channel_50'}.\",)", + "args": "(\"Parameter must be set to one of the allowed values of {'flex_1channel_50', 'flex_8channel_50'}.\",)", "class": "ParameterValueError", - "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultChoiceNoMatchChoice_Override_str_default_no_matching_choices.py\", line 48, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 157, in add_str\n parameter = parameter_definition.create_str_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 262, in create_str_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 105, in __init__\n self.value: PrimitiveAllowedTypes = default\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 116, in value\n raise ParameterValueError(\n" + "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultChoiceNoMatchChoice_Override_str_default_no_matching_choices.py\", line 48, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 157, in add_str\n parameter = parameter_definition.create_str_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 263, in create_str_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 106, in __init__\n self.value: PrimitiveAllowedTypes = default\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 117, in value\n raise ParameterValueError(\n" }, "errorType": "PythonException", "isDefined": false, diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[7d06568bfe][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_choice_display_name].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[7d06568bfe][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_choice_display_name].json index 3ae56417b74..126f0438279 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[7d06568bfe][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_choice_display_name].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[7d06568bfe][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_choice_display_name].json @@ -21,7 +21,7 @@ "errorInfo": { "args": "('Display name must be a string and at most 30 characters.',)", "class": "ParameterNameError", - "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_choice_display_name.py\", line 51, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 157, in add_str\n parameter = parameter_definition.create_str_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 262, in create_str_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 94, in __init__\n validation.validate_options(default, minimum, maximum, choices, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 264, in validate_options\n _validate_choices(minimum, maximum, choices, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 189, in _validate_choices\n ensure_display_name(display_name)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 33, in ensure_display_name\n raise ParameterNameError(\n" + "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_choice_display_name.py\", line 51, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 157, in add_str\n parameter = parameter_definition.create_str_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 263, in create_str_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 95, in __init__\n validation.validate_options(default, minimum, maximum, choices, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 264, in validate_options\n _validate_choices(minimum, maximum, choices, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 189, in _validate_choices\n ensure_display_name(display_name)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 33, in ensure_display_name\n raise ParameterNameError(\n" }, "errorType": "PythonException", "isDefined": false, diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[7f2ef0eaff][Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultChoiceNoMatchChoice_Override_float_default_no_matching_choices].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[7f2ef0eaff][Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultChoiceNoMatchChoice_Override_float_default_no_matching_choices].json index e9b9c22e4c0..464e58cb1fd 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[7f2ef0eaff][Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultChoiceNoMatchChoice_Override_float_default_no_matching_choices].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[7f2ef0eaff][Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultChoiceNoMatchChoice_Override_float_default_no_matching_choices].json @@ -21,7 +21,7 @@ "errorInfo": { "args": "('Parameter must be set to one of the allowed values of {160.0, 100.0, 200.0}.',)", "class": "ParameterValueError", - "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultChoiceNoMatchChoice_Override_float_default_no_matching_choices.py\", line 36, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 98, in add_float\n parameter = parameter_definition.create_float_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 223, in create_float_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 105, in __init__\n self.value: PrimitiveAllowedTypes = default\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 116, in value\n raise ParameterValueError(\n" + "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_DefaultChoiceNoMatchChoice_Override_float_default_no_matching_choices.py\", line 36, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 98, in add_float\n parameter = parameter_definition.create_float_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 224, in create_float_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 106, in __init__\n self.value: PrimitiveAllowedTypes = default\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 117, in value\n raise ParameterValueError(\n" }, "errorType": "PythonException", "isDefined": false, diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[8860ee702c][OT2_S_v2_14_P300M_P20S_HS_TC_TM_SmokeTestV3].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[8860ee702c][OT2_S_v2_14_P300M_P20S_HS_TC_TM_SmokeTestV3].json index 5390891d512..b33a27f2bfb 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[8860ee702c][OT2_S_v2_14_P300M_P20S_HS_TC_TM_SmokeTestV3].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[8860ee702c][OT2_S_v2_14_P300M_P20S_HS_TC_TM_SmokeTestV3].json @@ -17,41 +17,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Let there be light! True 🌠🌠🌠", - "legacyCommandType": "command.COMMENT" + "message": "Let there be light! True 🌠🌠🌠" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Is the door is closed? True 🚪🚪🚪", - "legacyCommandType": "command.COMMENT" + "message": "Is the door is closed? True 🚪🚪🚪" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Is this a simulation? True 🔮🔮🔮", - "legacyCommandType": "command.COMMENT" + "message": "Is this a simulation? True 🔮🔮🔮" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Running against API Version: 2.14", - "legacyCommandType": "command.COMMENT" + "message": "Running against API Version: 2.14" }, "result": {}, "status": "succeeded" diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[88a20da279][Flex_S_v2_15_P50M_P1000M_KAPALibraryQuantLongv2].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[88a20da279][Flex_S_v2_15_P50M_P1000M_KAPALibraryQuantLongv2].json index 24f2c1e2fb6..7438c45728d 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[88a20da279][Flex_S_v2_15_P50M_P1000M_KAPALibraryQuantLongv2].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[88a20da279][Flex_S_v2_15_P50M_P1000M_KAPALibraryQuantLongv2].json @@ -8,11 +8,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "THIS IS A DRY RUN", - "legacyCommandType": "command.COMMENT" + "message": "THIS IS A DRY RUN" }, "result": {}, "status": "succeeded" @@ -17874,51 +17873,46 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Flex_S_v2_15_P50M_P1000M_KAPALibraryQuantLongv2.py", - "legacyCommandType": "command.COMMENT" + "message": "Flex_S_v2_15_P50M_P1000M_KAPALibraryQuantLongv2.py" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "There are 24 Samples", - "legacyCommandType": "command.COMMENT" + "message": "There are 24 Samples" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Dispensing Diluent Part 1 and Part 2", - "legacyCommandType": "command.COMMENT" + "message": "--> Dispensing Diluent Part 1 and Part 2" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -19189,31 +19183,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding Sample to Diluent Part 1", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding Sample to Diluent Part 1" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -19525,11 +19516,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Mixing", - "legacyCommandType": "command.COMMENT" + "message": "--> Mixing" }, "result": {}, "status": "succeeded" @@ -27656,31 +27646,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding Diluted Sample to Diluent Part 2", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding Diluted Sample to Diluent Part 2" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -27992,11 +27979,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Mixing", - "legacyCommandType": "command.COMMENT" + "message": "--> Mixing" }, "result": {}, "status": "succeeded" @@ -36123,31 +36109,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding qPCR Mix", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding qPCR Mix" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -36669,31 +36652,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding Standards to Mix", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding Standards to Mix" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -36969,31 +36949,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding Diluted Sample to Mix", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding Diluted Sample to Mix" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -37809,31 +37786,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Dispensing 384 well", - "legacyCommandType": "command.COMMENT" + "message": "--> Dispensing 384 well" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -54455,31 +54429,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding qPCR Mix", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding qPCR Mix" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -55001,31 +54972,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding Standards to Mix", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding Standards to Mix" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -55301,31 +55269,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding Diluted Sample to Mix", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding Diluted Sample to Mix" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -56141,31 +56106,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Dispensing 384 well", - "legacyCommandType": "command.COMMENT" + "message": "--> Dispensing 384 well" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -72787,31 +72749,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding qPCR Mix", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding qPCR Mix" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -73333,31 +73292,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding Standards to Mix", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding Standards to Mix" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -73633,31 +73589,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding Diluted Sample to Mix", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding Diluted Sample to Mix" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -74473,31 +74426,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Dispensing 384 well", - "legacyCommandType": "command.COMMENT" + "message": "--> Dispensing 384 well" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -91119,31 +91069,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding qPCR Mix", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding qPCR Mix" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -91665,31 +91612,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding Standards to Mix", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding Standards to Mix" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -91965,31 +91909,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding Diluted Sample to Mix", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding Diluted Sample to Mix" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -92805,31 +92746,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Dispensing 384 well", - "legacyCommandType": "command.COMMENT" + "message": "--> Dispensing 384 well" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -109451,31 +109389,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding qPCR Mix", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding qPCR Mix" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -109997,31 +109932,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding Standards to Mix", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding Standards to Mix" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -110297,31 +110229,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding Diluted Sample to Mix", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding Diluted Sample to Mix" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -111137,31 +111066,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Dispensing 384 well", - "legacyCommandType": "command.COMMENT" + "message": "--> Dispensing 384 well" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -127783,31 +127709,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding qPCR Mix", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding qPCR Mix" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -128329,31 +128252,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding Standards to Mix", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding Standards to Mix" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -128629,31 +128549,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding Diluted Sample to Mix", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding Diluted Sample to Mix" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -129469,31 +129386,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Dispensing 384 well", - "legacyCommandType": "command.COMMENT" + "message": "--> Dispensing 384 well" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[a06502b2dc][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_description].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[a06502b2dc][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_description].json index ad37127d4fa..db2f1fdeb3b 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[a06502b2dc][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_description].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[a06502b2dc][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_description].json @@ -21,7 +21,7 @@ "errorInfo": { "args": "('Description must be a string and at most 100 characters.',)", "class": "ParameterNameError", - "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_description.py\", line 84, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 157, in add_str\n parameter = parameter_definition.create_str_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 262, in create_str_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 79, in __init__\n self._description = validation.ensure_description(description)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 60, in ensure_description\n raise ParameterNameError(\n" + "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_description.py\", line 84, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 157, in add_str\n parameter = parameter_definition.create_str_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 263, in create_str_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 80, in __init__\n self._description = validation.ensure_description(description)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 60, in ensure_description\n raise ParameterNameError(\n" }, "errorType": "PythonException", "isDefined": false, diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[ac886d7768][Flex_S_v2_15_P1000_96_GRIP_HS_MB_TC_TM_IDTXgen96Part1to3].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[ac886d7768][Flex_S_v2_15_P1000_96_GRIP_HS_MB_TC_TM_IDTXgen96Part1to3].json index 4c4f786b5e0..b77e6e07cf6 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[ac886d7768][Flex_S_v2_15_P1000_96_GRIP_HS_MB_TC_TM_IDTXgen96Part1to3].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[ac886d7768][Flex_S_v2_15_P1000_96_GRIP_HS_MB_TC_TM_IDTXgen96Part1to3].json @@ -8,21 +8,19 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "THIS IS A DRY RUN", - "legacyCommandType": "command.COMMENT" + "message": "THIS IS A DRY RUN" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "USED TIPS WILL BE RE-RACKED", - "legacyCommandType": "command.COMMENT" + "message": "USED TIPS WILL BE RE-RACKED" }, "result": {}, "status": "succeeded" @@ -10986,41 +10984,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Fragmenting / End Repair / A-Tailing", - "legacyCommandType": "command.COMMENT" + "message": "--> Fragmenting / End Repair / A-Tailing" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding FRERAT", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding FRERAT" }, "result": {}, "status": "succeeded" diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[ad9184067d][Flex_X_v2_18_NO_PIPETTES_ReservedWord].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[ad9184067d][Flex_X_v2_18_NO_PIPETTES_ReservedWord].json index 23348d50589..78bffd6ddfe 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[ad9184067d][Flex_X_v2_18_NO_PIPETTES_ReservedWord].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[ad9184067d][Flex_X_v2_18_NO_PIPETTES_ReservedWord].json @@ -21,7 +21,7 @@ "errorInfo": { "args": "('Variable name cannot be a reserved Python keyword.',)", "class": "ParameterNameError", - "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_ReservedWord.py\", line 13, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 61, in add_int\n parameter = parameter_definition.create_int_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 199, in create_int_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 78, in __init__\n self._variable_name = validation.ensure_variable_name(variable_name)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 52, in ensure_variable_name\n raise ParameterNameError(\"Variable name cannot be a reserved Python keyword.\")\n" + "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_ReservedWord.py\", line 13, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 61, in add_int\n parameter = parameter_definition.create_int_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 200, in create_int_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 79, in __init__\n self._variable_name = validation.ensure_variable_name(variable_name)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 52, in ensure_variable_name\n raise ParameterNameError(\"Variable name cannot be a reserved Python keyword.\")\n" }, "errorType": "PythonException", "isDefined": false, diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[b806f07be9][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_choice_value].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[b806f07be9][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_choice_value].json index fa7d0e50a9c..4a89f756f82 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[b806f07be9][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_choice_value].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[b806f07be9][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_choice_value].json @@ -21,7 +21,7 @@ "errorInfo": { "args": "(\"All choices provided must be of type 'str'\",)", "class": "ParameterDefinitionError", - "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_choice_value.py\", line 62, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 157, in add_str\n parameter = parameter_definition.create_str_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 262, in create_str_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 94, in __init__\n validation.validate_options(default, minimum, maximum, choices, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 264, in validate_options\n _validate_choices(minimum, maximum, choices, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 191, in _validate_choices\n raise ParameterDefinitionError(\n" + "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_choice_value.py\", line 62, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 157, in add_str\n parameter = parameter_definition.create_str_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 263, in create_str_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 95, in __init__\n validation.validate_options(default, minimum, maximum, choices, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 264, in validate_options\n _validate_choices(minimum, maximum, choices, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 191, in _validate_choices\n raise ParameterDefinitionError(\n" }, "errorType": "PythonException", "isDefined": false, diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[baf79d9b4a][Flex_S_v2_15_P1000S_None_SimpleNormalizeLongRight].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[baf79d9b4a][Flex_S_v2_15_P1000S_None_SimpleNormalizeLongRight].json index 448aba2d148..87c86016926 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[baf79d9b4a][Flex_S_v2_15_P1000S_None_SimpleNormalizeLongRight].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[baf79d9b4a][Flex_S_v2_15_P1000S_None_SimpleNormalizeLongRight].json @@ -8,21 +8,19 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "THIS IS A REACTION RUN", - "legacyCommandType": "command.COMMENT" + "message": "THIS IS A REACTION RUN" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "THIS IS A NO MODULE RUN", - "legacyCommandType": "command.COMMENT" + "message": "THIS IS A NO MODULE RUN" }, "result": {}, "status": "succeeded" @@ -10694,31 +10692,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Adding Dye Sample Plate 1", - "legacyCommandType": "command.COMMENT" + "message": "Adding Dye Sample Plate 1" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -15714,31 +15709,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Adding Diluent Sample Plate 1", - "legacyCommandType": "command.COMMENT" + "message": "Adding Diluent Sample Plate 1" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -25434,31 +25426,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Adding Dye Sample Plate 2", - "legacyCommandType": "command.COMMENT" + "message": "Adding Dye Sample Plate 2" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -30454,31 +30443,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Adding Diluent Sample Plate 2", - "legacyCommandType": "command.COMMENT" + "message": "Adding Diluent Sample Plate 2" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -40174,31 +40160,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Adding Dye Sample Plate 3", - "legacyCommandType": "command.COMMENT" + "message": "Adding Dye Sample Plate 3" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -45194,31 +45177,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Adding Diluent Sample Plate 3", - "legacyCommandType": "command.COMMENT" + "message": "Adding Diluent Sample Plate 3" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -54914,31 +54894,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Adding Dye Sample Plate 1", - "legacyCommandType": "command.COMMENT" + "message": "Adding Dye Sample Plate 1" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -59934,31 +59911,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Adding Diluent Sample Plate 1", - "legacyCommandType": "command.COMMENT" + "message": "Adding Diluent Sample Plate 1" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -69654,31 +69628,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Adding Dye Sample Plate 2", - "legacyCommandType": "command.COMMENT" + "message": "Adding Dye Sample Plate 2" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -74674,31 +74645,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Adding Diluent Sample Plate 2", - "legacyCommandType": "command.COMMENT" + "message": "Adding Diluent Sample Plate 2" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -84394,31 +84362,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Adding Dye Sample Plate 3", - "legacyCommandType": "command.COMMENT" + "message": "Adding Dye Sample Plate 3" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -89414,31 +89379,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Adding Diluent Sample Plate 3", - "legacyCommandType": "command.COMMENT" + "message": "Adding Diluent Sample Plate 3" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[d48bc4f0c9][OT2_S_v2_17_P300M_P20S_HS_TC_TM_SmokeTestV3].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[d48bc4f0c9][OT2_S_v2_17_P300M_P20S_HS_TC_TM_SmokeTestV3].json index adfb07cea53..e9f6c59a0b9 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[d48bc4f0c9][OT2_S_v2_17_P300M_P20S_HS_TC_TM_SmokeTestV3].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[d48bc4f0c9][OT2_S_v2_17_P300M_P20S_HS_TC_TM_SmokeTestV3].json @@ -17,41 +17,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Let there be light! True 🌠🌠🌠", - "legacyCommandType": "command.COMMENT" + "message": "Let there be light! True 🌠🌠🌠" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Is the door is closed? True 🚪🚪🚪", - "legacyCommandType": "command.COMMENT" + "message": "Is the door is closed? True 🚪🚪🚪" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Is this a simulation? True 🔮🔮🔮", - "legacyCommandType": "command.COMMENT" + "message": "Is this a simulation? True 🔮🔮🔮" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Running against API Version: 2.17", - "legacyCommandType": "command.COMMENT" + "message": "Running against API Version: 2.17" }, "result": {}, "status": "succeeded" diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[d7e862d601][OT2_S_v2_18_None_None_duplicateChoiceValue].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[d7e862d601][OT2_S_v2_18_None_None_duplicateChoiceValue].json index 792ce852c07..18dae971b7f 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[d7e862d601][OT2_S_v2_18_None_None_duplicateChoiceValue].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[d7e862d601][OT2_S_v2_18_None_None_duplicateChoiceValue].json @@ -8,11 +8,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "variable pipette has value flex_1channel_50", - "legacyCommandType": "command.COMMENT" + "message": "variable pipette has value flex_1channel_50" }, "result": {}, "status": "succeeded" diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[de4249ddfb][Flex_X_v2_16_NO_PIPETTES_TC_TrashBinAndThermocyclerConflict].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[de4249ddfb][Flex_X_v2_16_NO_PIPETTES_TC_TrashBinAndThermocyclerConflict].json index 07aec3af674..105ec75b916 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[de4249ddfb][Flex_X_v2_16_NO_PIPETTES_TC_TrashBinAndThermocyclerConflict].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[de4249ddfb][Flex_X_v2_16_NO_PIPETTES_TC_TrashBinAndThermocyclerConflict].json @@ -138,7 +138,7 @@ "errorInfo": { "args": "('thermocyclerModuleV2 in slot B1 prevents trash bin from using slot A1.',)", "class": "DeckConflictError", - "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 147, in exec_run\n exec(\"run(__context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_16_NO_PIPETTES_TC_TrashBinAndThermocyclerConflict.py\", line 13, in run\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/api_support/util.py\", line 383, in _check_version_wrapper\n return decorated_obj(*args, **kwargs)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/protocol_context.py\", line 530, in load_trash_bin\n trash_bin = self._core.load_trash_bin(slot_name, addressable_area_name)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/core/engine/protocol.py\", line 530, in load_trash_bin\n self._add_disposal_location_to_engine(trash_bin)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/core/engine/protocol.py\", line 149, in _add_disposal_location_to_engine\n deck_conflict.check(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/core/engine/deck_conflict.py\", line 203, in check\n wrapped_deck_conflict.check(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/motion_planning/deck_conflict.py\", line 210, in check\n raise DeckConflictError(\n" + "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 147, in exec_run\n exec(\"run(__context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_16_NO_PIPETTES_TC_TrashBinAndThermocyclerConflict.py\", line 13, in run\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/api_support/util.py\", line 383, in _check_version_wrapper\n return decorated_obj(*args, **kwargs)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/protocol_context.py\", line 530, in load_trash_bin\n trash_bin = self._core.load_trash_bin(slot_name, addressable_area_name)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/core/engine/protocol.py\", line 541, in load_trash_bin\n self._add_disposal_location_to_engine(trash_bin)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/core/engine/protocol.py\", line 150, in _add_disposal_location_to_engine\n deck_conflict.check(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/core/engine/deck_conflict.py\", line 203, in check\n wrapped_deck_conflict.check(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/motion_planning/deck_conflict.py\", line 210, in check\n raise DeckConflictError(\n" }, "errorType": "PythonException", "isDefined": false, diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[e496fec176][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_default].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[e496fec176][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_default].json index 79866f5bf13..a4b62b44fa1 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[e496fec176][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_default].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[e496fec176][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_default].json @@ -21,7 +21,7 @@ "errorInfo": { "args": "(\"Parameter default 6 has type 'int', but must be of type 'str'.\",)", "class": "ParameterValueError", - "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_default.py\", line 73, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 157, in add_str\n parameter = parameter_definition.create_str_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 262, in create_str_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 94, in __init__\n validation.validate_options(default, minimum, maximum, choices, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 253, in validate_options\n raise ParameterValueError(\n" + "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_default.py\", line 73, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 157, in add_str\n parameter = parameter_definition.create_str_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 263, in create_str_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 95, in __init__\n validation.validate_options(default, minimum, maximum, choices, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 253, in validate_options\n raise ParameterValueError(\n" }, "errorType": "PythonException", "isDefined": false, diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[e907467039][Flex_S_v2_15_P1000M_P50M_GRIP_HS_MB_TC_TM_IlluminaDNAPrep24x].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[e907467039][Flex_S_v2_15_P1000M_P50M_GRIP_HS_MB_TC_TM_IlluminaDNAPrep24x].json index 804d710eeff..9ba0caeda8e 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[e907467039][Flex_S_v2_15_P1000M_P50M_GRIP_HS_MB_TC_TM_IlluminaDNAPrep24x].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[e907467039][Flex_S_v2_15_P1000M_P50M_GRIP_HS_MB_TC_TM_IlluminaDNAPrep24x].json @@ -8,11 +8,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "THIS IS A REACTION RUN", - "legacyCommandType": "command.COMMENT" + "message": "THIS IS A REACTION RUN" }, "result": {}, "status": "succeeded" @@ -8173,11 +8172,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "SETTING THERMO and TEMP BLOCK Temperature", - "legacyCommandType": "command.COMMENT" + "message": "SETTING THERMO and TEMP BLOCK Temperature" }, "result": {}, "status": "succeeded" @@ -8261,41 +8259,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Tagment", - "legacyCommandType": "command.COMMENT" + "message": "--> Tagment" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ADDING TAGMIX", - "legacyCommandType": "command.COMMENT" + "message": "--> ADDING TAGMIX" }, "result": {}, "status": "succeeded" @@ -10458,11 +10452,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding TAGSTOP", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding TAGSTOP" }, "result": {}, "status": "succeeded" @@ -12483,41 +12476,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Cleanup", - "legacyCommandType": "command.COMMENT" + "message": "--> Cleanup" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Supernatant" }, "result": {}, "status": "succeeded" @@ -13363,11 +13352,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Wash ", - "legacyCommandType": "command.COMMENT" + "message": "--> Wash " }, "result": {}, "status": "succeeded" @@ -14400,11 +14388,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Remove Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> Remove Wash" }, "result": {}, "status": "succeeded" @@ -15250,11 +15237,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Wash ", - "legacyCommandType": "command.COMMENT" + "message": "--> Wash " }, "result": {}, "status": "succeeded" @@ -16287,11 +16273,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Remove Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> Remove Wash" }, "result": {}, "status": "succeeded" @@ -17137,11 +17122,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Wash ", - "legacyCommandType": "command.COMMENT" + "message": "--> Wash " }, "result": {}, "status": "succeeded" @@ -18174,11 +18158,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Remove Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> Remove Wash" }, "result": {}, "status": "succeeded" @@ -18997,11 +18980,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Residual Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Residual Wash" }, "result": {}, "status": "succeeded" @@ -19352,11 +19334,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding EPM", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding EPM" }, "result": {}, "status": "succeeded" @@ -21235,11 +21216,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding Barcodes", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding Barcodes" }, "result": {}, "status": "succeeded" @@ -22175,31 +22155,28 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Cleanup", - "legacyCommandType": "command.COMMENT" + "message": "--> Cleanup" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "==============================================", - "legacyCommandType": "command.COMMENT" + "message": "==============================================" }, "result": {}, "status": "succeeded" @@ -22241,11 +22218,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding H20 and SAMPLE", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding H20 and SAMPLE" }, "result": {}, "status": "succeeded" @@ -22713,11 +22689,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ADDING AMPure (0.8x)", - "legacyCommandType": "command.COMMENT" + "message": "--> ADDING AMPure (0.8x)" }, "result": {}, "status": "succeeded" @@ -24841,11 +24816,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Supernatant" }, "result": {}, "status": "succeeded" @@ -25721,11 +25695,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ETOH Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> ETOH Wash" }, "result": {}, "status": "succeeded" @@ -26549,11 +26522,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Remove ETOH Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> Remove ETOH Wash" }, "result": {}, "status": "succeeded" @@ -27429,11 +27401,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> ETOH Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> ETOH Wash" }, "result": {}, "status": "succeeded" @@ -28257,11 +28228,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Remove ETOH Wash", - "legacyCommandType": "command.COMMENT" + "message": "--> Remove ETOH Wash" }, "result": {}, "status": "succeeded" @@ -29146,11 +29116,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Removing Residual ETOH", - "legacyCommandType": "command.COMMENT" + "message": "--> Removing Residual ETOH" }, "result": {}, "status": "succeeded" @@ -29822,11 +29791,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Adding RSB", - "legacyCommandType": "command.COMMENT" + "message": "--> Adding RSB" }, "result": {}, "status": "succeeded" @@ -31698,11 +31666,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "--> Transferring Supernatant", - "legacyCommandType": "command.COMMENT" + "message": "--> Transferring Supernatant" }, "result": {}, "status": "succeeded" diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[f24bb0b4d9][Flex_S_v2_15_P1000_96_GRIP_HS_MB_TC_TM_IlluminaDNAPrep96PART3].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[f24bb0b4d9][Flex_S_v2_15_P1000_96_GRIP_HS_MB_TC_TM_IlluminaDNAPrep96PART3].json index 77acd8c8cb6..24d2e31f79f 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[f24bb0b4d9][Flex_S_v2_15_P1000_96_GRIP_HS_MB_TC_TM_IlluminaDNAPrep96PART3].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[f24bb0b4d9][Flex_S_v2_15_P1000_96_GRIP_HS_MB_TC_TM_IlluminaDNAPrep96PART3].json @@ -8,11 +8,10 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "THIS IS A DRY RUN", - "legacyCommandType": "command.COMMENT" + "message": "THIS IS A DRY RUN" }, "result": {}, "status": "succeeded" diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[f88b7d6e30][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_display_name].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[f88b7d6e30][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_display_name].json index 0f8854160b2..faf3961d7d6 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[f88b7d6e30][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_display_name].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[f88b7d6e30][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_display_name].json @@ -21,7 +21,7 @@ "errorInfo": { "args": "('Display name must be a string and at most 30 characters.',)", "class": "ParameterNameError", - "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_display_name.py\", line 30, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 61, in add_int\n parameter = parameter_definition.create_int_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 199, in create_int_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 77, in __init__\n self._display_name = validation.ensure_display_name(display_name)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 33, in ensure_display_name\n raise ParameterNameError(\n" + "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"\", line 1, in \n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_display_name.py\", line 30, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 61, in add_int\n parameter = parameter_definition.create_int_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 200, in create_int_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 78, in __init__\n self._display_name = validation.ensure_display_name(display_name)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 33, in ensure_display_name\n raise ParameterNameError(\n" }, "errorType": "PythonException", "isDefined": false, diff --git a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[fc60ef9cbd][OT2_S_v2_16_P300M_P20S_HS_TC_TM_dispense_changes].json b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[fc60ef9cbd][OT2_S_v2_16_P300M_P20S_HS_TC_TM_dispense_changes].json index e98baefe075..826fccf8264 100644 --- a/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[fc60ef9cbd][OT2_S_v2_16_P300M_P20S_HS_TC_TM_dispense_changes].json +++ b/app-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[fc60ef9cbd][OT2_S_v2_16_P300M_P20S_HS_TC_TM_dispense_changes].json @@ -17,41 +17,37 @@ "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Let there be light! True 🌠🌠🌠", - "legacyCommandType": "command.COMMENT" + "message": "Let there be light! True 🌠🌠🌠" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Is the door is closed? True 🚪🚪🚪", - "legacyCommandType": "command.COMMENT" + "message": "Is the door is closed? True 🚪🚪🚪" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Is this a simulation? True 🔮🔮🔮", - "legacyCommandType": "command.COMMENT" + "message": "Is this a simulation? True 🔮🔮🔮" }, "result": {}, "status": "succeeded" }, { - "commandType": "custom", + "commandType": "comment", "notes": [], "params": { - "legacyCommandText": "Running against API Version: 2.16", - "legacyCommandType": "command.COMMENT" + "message": "Running against API Version: 2.16" }, "result": {}, "status": "succeeded"