Test the OpenSPP modules that are migrated to Odoo 17

[dasunhegoda]

1. No unique ID for Group and Individual
   Ticket: Improve odoo import for registrant #247

2. No Import Match, no Custom Fields, no Country Office in Registry > Configuration
   Tickets:

• Extend Importing Function with the Import Matching #5
• Add a way to recompute the indicator fields that are set to be recomputed daily #216
• Create a module that allow to create country office (aka company in odoo) and configure it #3

3. No import in the background checkbox on the left side of the screen when importing a file.
   Ticket: Improve the odoo import to support async #1

4. No top-up card or any cards in Individuals and Groups
   Ticket: Extend ID Document to support top-up card #249

5. No Program ID
   Ticket: Add a field program_id to each program. It is a string auto generated with the format: PROG_{SEQ} #88

6. No SQL-based Eligibility Manager, no Tag-based Eligibility Manager, no Compliance Criteria in Set Program Settings
   Tickets:

• implement a SQL eligibility manager #89
• Add a new enrollment manager that is based on tag+Area #86
• Implement compliance criteria #90

7. No Store Service Points to Entitlements checkbox in Entitlement Manager
   Tickets:

• Implement different way to associate service points to entitlements #83
• Enhance API and UI to Filter Service Points by Program #64

8. No local and global roles
   Ticket: Standardize user roles #2

9. No unique ID for Area and Service Points
   Ticket: create unique id on areas & service points for integrate with OpenFN #273

10. No Contacts, no OpenAPI in Home Menu
    Tickets:

• Associate a company and contacts to each service point. #245
• Setting up Swagger documentation for the APIs #70

11. No Import from Registry in Registry for the OpenCRVS Integration
    Ticket: G2P Connect API Implementation - OpenCRVS Integration #67

12. No DCI API Client Credentials in Settings
    Ticket: G2P Connect API Implementation - OpenCRVS Integration #67

13. No option to add negative criteria
    Ticket: In the enrollment module, Add an option to add negative criterias #18

14. Amount per Cycle column behavior in Entitlement Manager for Cash
    https://drive.google.com/file/d/198GySHEb4zXhfbOU4gDQdP1wDbwajlKX/view?usp=sharing

15. No Approve Entitlements button for In-kind Entitlements (unlike in Cash), resulting to Approved state but entitlements are still in Pending Validation.
    

16. PMT Score of Group is not updating when Default Weight is changed.
    https://drive.google.com/file/d/1dDbUqWkwmMU3ltsR8mxZBRMQBoL9rUZh/view?usp=sharing

17. Random error message appears in Custom Fields.

RPC_ERROR
Odoo Server Error
Traceback (most recent call last):
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 1765, in _serve_db
return service_model.retrying(self._serve_ir_http, self.env)
File "/opt/odoo/custom/src/odoo/odoo/service/model.py", line 133, in retrying
result = func()
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 1792, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 1996, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "/opt/odoo/custom/src/odoo/odoo/addons/base/models/ir_http.py", line 222, in _dispatch
result = endpoint(**request.params)
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 722, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "/opt/odoo/auto/addons/web/controllers/dataset.py", line 24, in call_kw
return self._call_kw(model, method, args, kwargs)
File "/opt/odoo/auto/addons/web/controllers/dataset.py", line 20, in _call_kw
return call_kw(request.env[model], method, args, kwargs)
File "/opt/odoo/custom/src/odoo/odoo/api.py", line 468, in call_kw
result = _call_kw_multi(method, model, args, kwargs)
File "/opt/odoo/custom/src/odoo/odoo/api.py", line 453, in _call_kw_multi
result = method(recs, *args, **kwargs)
File "/opt/odoo/auto/addons/web/models/models.py", line 76, in web_save
return self.with_context(bin_size=True).web_read(specification)
File "/opt/odoo/auto/addons/web/models/models.py", line 86, in web_read
values_list: List[Dict] = self.read(fields_to_read, load=None)
File "/opt/odoo/custom/src/odoo/odoo/models.py", line 3539, in read
self._origin.fetch(fields)
File "/opt/odoo/custom/src/odoo/odoo/models.py", line 3827, in fetch
fetched = self._fetch_query(query, fields_to_fetch)
File "/opt/odoo/custom/src/odoo/odoo/models.py", line 3940, in _fetch_query
field.read(fetched)
File "/opt/odoo/custom/src/odoo/odoo/fields.py", line 4821, in read
query.order = comodel._order_to_sql(comodel._order, query)
File "/opt/odoo/custom/src/odoo/odoo/models.py", line 5163, in _order_to_sql
term = self._order_field_to_sql(alias, field_name, sql_direction, sql_nulls, query)
File "/opt/odoo/custom/src/odoo/odoo/models.py", line 5184, in _order_field_to_sql
raise ValueError(f"Invalid field {field_name!r} on model {self._name!r}")
ValueError: Invalid field 'id' on model '_unknown'

The above server error caused the following client error:
RPC_ERROR: Odoo Server Error
at makeErrorFromResponse (https://acf-dev.newlogic-demo.com/web/assets/fc5753c/web.assets_web.min.js:2879:163)
at XMLHttpRequest. (https://acf-dev.newlogic-demo.com/web/assets/fc5753c/web.assets_web.min.js:2883:13)

18. Cannot delete a Rule in Audit Rule page.

RPC_ERROR
Odoo Server Error
Traceback (most recent call last):
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 1765, in _serve_db
return service_model.retrying(self._serve_ir_http, self.env)
File "/opt/odoo/custom/src/odoo/odoo/service/model.py", line 133, in retrying
result = func()
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 1792, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 1996, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "/opt/odoo/custom/src/odoo/odoo/addons/base/models/ir_http.py", line 222, in _dispatch
result = endpoint(**request.params)
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 722, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "/opt/odoo/auto/addons/web/controllers/dataset.py", line 24, in call_kw
return self._call_kw(model, method, args, kwargs)
File "/opt/odoo/auto/addons/web/controllers/dataset.py", line 20, in _call_kw
return call_kw(request.env[model], method, args, kwargs)
File "/opt/odoo/custom/src/odoo/odoo/api.py", line 468, in call_kw
result = _call_kw_multi(method, model, args, kwargs)
File "/opt/odoo/custom/src/odoo/odoo/api.py", line 453, in _call_kw_multi
result = method(recs, *args, **kwargs)
File "/opt/odoo/auto/addons/spp_audit_log/models/spp_audit_rule.py", line 177, in unlink
audit_rule_count = self.env["spp.audit.rule"].search(
TypeError: BaseModel.search() got an unexpected keyword argument 'count'

The above server error caused the following client error:
RPC_ERROR: Odoo Server Error
at makeErrorFromResponse (https://acf-dev.newlogic-demo.com/web/assets/debug/web.assets_web.js:27818:19)
at XMLHttpRequest. (https://acf-dev.newlogic-demo.com/web/assets/debug/web.assets_web.js:27866:27)

19. Error message when clicking View Logs.
    

20. In Programs > Configuration > General Settings > Program Settings.
    No Setting Found error is still displaying even when Program Setting is already clicked.
    

21. Select a Program with Compliance Criteria. Click Configuration. Scroll down to Compliance Manager.
    The Compliance is not displayed properly.
    https://github.com/OpenSPP/openspp-modules/assets/138551361/4cfa5070-787f-4ed4-bee8-13e02f2aefb6

22. SQL Record Count is always zero in Compliance Criteria
    

[dasunhegoda]

@celinenilla @adriancris : These are core functionalities that need to be fixed before the release. So I added the ticket to the iteration 21.

[jeremi]

1. No unique ID for Group and Individual
   Ticket: Improve odoo import for registrant #247

@dasunhegoda what is the issue with this? I think it has been implemented, no?

[dasunhegoda]

It has been implemented but it's not showing in the UI after the Odoo 17 update @jeremi.

[reichie020212]

@dasunhegoda I did a quick investigation on these issues and here are my comments per issues

1. Install "OpenSPP: Import Improvement"
2. • for Import Match, Install "OpenSPP Import Matching"

• for Custom Fields, Install "OpenSPP Custom Field: Recompute Daily"
• for Country Office, Install "OpenSPP Base Settings"

4. Install "OpenSPP Base"
5. Install "OpenSPP Programs: Import"
6. Install the following modules:

• OpenSPP SQL Query Eligibility Manager
• OpenSPP Tag Based Eligibility Manager
• OpenSPP Programs: Compliance Criteria

7. Install "OpenSPP Programs (Service Points Integration)"
8. Install User Roles Management
9. Install "OpenSPP: Import Improvement"
10. • for the OpenAPI, just install "OpenSPP REST API"

• for the Contacts, it will be hidden if the module "OpenSPP Theme (Muk Theme)" is installed, but you can unhide the Contacts by going to Settings -> Users & Companies -> Users -> select current user -> Access Rights -> Check the access right "Hide Menu" then save

11. The "Import From Registry" is not located in Registry but in the Program. Install "OpenSPP Import: DCI API".
12. Install "OpenSPP API: DCI Server"
13. Install "OpenSPP Create Program Wizard Exclusion"

15 . Already tackled on this ticket: #420
18 . Need to fix the audit module to accomodate the changes from Odoo 15 to Odoo 17
19 . Need to investigate and fix the audit module.

Other issues that are missing in my comment is either I am not familiar on those issue or needs a thorough investigation.

[adriancris]

Checking @reichie020212's comments

[reichie020212]

@dasunhegoda I Tackled issue 18 and issue 19 about audit log in this ticket #436

[adriancris]

This is a reply to @reichie020212's investigation.

1. OpenSPP: Import Improvement - Installed

2. OpenSPP Import Matching - Installed
   OpenSPP Custom Field: Recompute Daily - Installed
   OpenSPP Base Settings - Installed

3. OpenSPP Base - Installed

4. OpenSPP Programs: Import - Installed

5. OpenSPP SQL Query Eligibility Manager - Installed
   OpenSPP Tag Based Eligibility Manager - Installed
   OpenSPP Programs: Compliance Criteria - Installed

6. OpenSPP Programs (Service Points Integration) - Installed

7. User Roles Management - Cannot install - Cannot activate "User Roles Management" module in ACF DEV #444

8. OpenSPP: Import Improvement - Installed

9. OpenSPP REST API - Cannot install - Cannot activate "OpenSPP REST API" in ACF DEV #445

10. OpenSPP Import: DCI API - Cannot install - Cannot activate "OpenSPP Import: DCI API" module in ACF DEV #446

11. OpenSPP API: DCI Server - Cannot install - Cannot activate "OpenSPP API: DCI Server" module in ACF DEV #447

12. OpenSPP Create Program Wizard Exclusion - Installed

[reichie020212]

@dasunhegoda here are some additional comments of some issues

issue 21: I fixed the UI issue and i created a new ticket for this #451
issue 22: Upon checking, "Validate Query" needs to click first to update the record count

[adriancris]

hi @reichie020212
*
*
*
issue 22: Upon checking, "Validate Query" needs to click first to update the record count
*
*
*
After clicking Validate Query, the record count is updated. But the modal closes. Is that expected behavior?

2024-06-11.22-14-43.mp4

[reichie020212]

hi @adriancris , i'm not sure if this is a expected behaviour since i'm not the one who built this but i'll try to ask @gonzalesedwin1123 or @emjay0921 .