Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some bug fixes #1087

Closed
wants to merge 7 commits into from
Closed

Conversation

DemiMarie
Copy link
Contributor

@DemiMarie DemiMarie commented Oct 11, 2020

See the individual commit messages for details.

Fixes #1089
Fixes #1077
Fixes #921
Fixes #1091
Fixes #1092

Automake treats $(top_srcdir) specially, so a variable that expands to
it won't work.  There were also bugs in the Makefile.am files that broke
`make distcheck`
@DemiMarie DemiMarie force-pushed the demi-builtin-delivery branch 5 times, most recently from 166eeb6 to 616fcf2 Compare October 12, 2020 19:15
@DemiMarie DemiMarie changed the title Built-in delivery methods Some bug fixes Oct 12, 2020
@DemiMarie DemiMarie force-pushed the demi-builtin-delivery branch 4 times, most recently from 6298f47 to 195c213 Compare October 14, 2020 18:02
This avoids having to use a shell for them.

Fixes OpenSMTPD#921
Otherwise, they would fail at delivery time, which would be harder to
debug.
This avoids the quoting problems that arise with %{mda}.
This avoids the risk that a compromised child process could send spoofed
userinfo values.
@poolpOrg
Copy link
Member

As discussed on the mailing list, this PR can't be accepted because it mixes portable-specific bits (which I will maintain on Github) and generic bits (inside smtpd/ subdirectory) which should be submitted to the OpenBSD developers directly.

@poolpOrg poolpOrg closed this Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants