-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
engine_pkcs11 leaks memory #475
Comments
Ssee #470 (comment) and make sure the free callback is also added. Further comments discuses OpenSSL 1.1 and OpenSSL 3.0 while engines are still available #471 tries to address the dup problem. |
I merged the commits from #471. Is this issue fixed now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey, I've implemented a custom memory tracking in BIND 9 for the external libraries, including OpenSSL, and it found that
engine_pkcs11
module is leaking following memory (lines should match OpenSSL 3.0.5):It's following methods:
ptr 0x55dd947bb8f0 size 24 file ../crypto/rsa/rsa_meth.c line 71
-->RSA_meth_set1_name()
ptr 0x55dd947bbbe0 size 120 file ../crypto/ec/ec_kmeth.c line 184
-->EC_KEY_METHOD_new()
ptr 0x55dd947bb980 size 120 file ../crypto/rsa/rsa_meth.c line 48
-->RSA_meth_dup()
ptr 0x55dd948287b0 size 264 file ../crypto/evp/pmeth_lib.c line 130
-->EVP_PKEY_meth_new()
The call tree can be found in the attached PDF: jeprof.pdf
This simple code
ENGINE_free(ENGINE_by_id("pkcs11"));
is enough to reproduce the issue.Looking at the code, it seems like the code that would free the method allocated in
PKCS11_get_rsa_method()
(and others) was never actually implemented:The text was updated successfully, but these errors were encountered: