feat(pkcs11-tool): an invalid signature is a fatal error #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3079a74
to
fa3c0f7
Compare
Jakuje
approved these changes
Jun 11, 2024
frankmorgner
approved these changes
Jun 12, 2024
xhanulik
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We are using the pkcs11-tool for the validation of the Trustonic HSM.
I noticed that the tool is not returning an error when a signature is invalid or when something bad happens during the signature verification.
I would expect something more than just a print.
This is why I am proposing to call util_fatal() which will exit with an error code different than 0.
I checked the patch with the Trustonic TEE HSM.
Regards,
Alexandre.