Avoid re-opening the log file for every debug message on Windows (fixes #824, superseedes #910) #913
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#910 fixes #824 by extending the logic for reopening the debug file for every log message. This approach, however, is very problematic in regard to performance.
Instead of building on sandy ground, this PR tries to solve #824 by reopening the debug file once, when needed. This improves overall performance for logging on Windows, simplifies the user configuration options and, of course, fixes the segmentation fault in question.
This PR is compile tested only and needs to be verified on Windows with a IASECC card.