Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SmartCard-HSM occasionally fails to generate secp521r1 signature #2623

Closed
rautammi opened this issue Oct 21, 2022 · 2 comments · Fixed by #3157
Closed

SmartCard-HSM occasionally fails to generate secp521r1 signature #2623

rautammi opened this issue Oct 21, 2022 · 2 comments · Fixed by #3157
Labels
bug

Comments

@rautammi
Copy link

Problem Description

Signing with an EC key on secp521r1 fails occasionally with CKR_DATA_INVALID.
See #2421

Method used in https://github.com/OpenSC/OpenSC/blob/master/src/libopensc/card-sc-hsm.c#L1051-L1055 does not work, as the case of datalen == 137 could be valid for both, 512 bit and 521 bit curves.

Proposed Resolution

Implement what was proposed by @dengert : #2421 (comment)
@Jakuje Jakuje added the bug label Sep 19, 2023
@frankmorgner
Copy link
Member

@CardContact please have a look

@no-usernames-left
Copy link

@CardContact Any luck on this?

@CardContact CardContact mentioned this issue May 24, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix2623and3155 CardContact/OpenSC
4 participants
@frankmorgner @Jakuje @no-usernames-left @rautammi