Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error #3134

Closed
connermemory opened this issue May 6, 2024 · 3 comments
Closed

Compilation error #3134

connermemory opened this issue May 6, 2024 · 3 comments

Comments

@connermemory
Copy link

I encountered an issue while compiling on Ubuntu 16.04, and I looked up previous issues. This issue has solved this problem, but I don't know why it has been restored now.
The gcc version I am using is 5.4.0.

reader-pcsc.c: In function ‘detect_reader_features’:
reader-pcsc.c:1229:5: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
     PIN_PROPERTIES_STRUCTURE_v5 *caps = (PIN_PROPERTIES_STRUCTURE_v5 *) &buf;
     ^
reader-pcsc.c:1238:5: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
     PIN_PROPERTIES_STRUCTURE *caps = (PIN_PROPERTIES_STRUCTURE *) buf;
     ^
cc1: all warnings being treated as errors
@frankmorgner
Copy link
Member

16.04 is not supported any longer. could it be that you're using an outdated version of OpenSC as well?

@Jakuje
Copy link
Member

Jakuje commented May 10, 2024

This was indeed fixed in #2241 but got back with a06abbf (from #2513) addressing some coverity concerns.

I would say that this old ubuntu is certainly unsupported, the same for the old gcc version. Given that this code works ok with all the current compilers, I would say this is really an gcc bug, which can be ignored by setting some compiler switches on your side, but there is really nothing we could do with it on our side.

@connermemory
Copy link
Author

Okay, thank you. I changed to Ubuntu 22.04 and it can be successfully compiled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants