-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set correct output length in PKCS#1 v1.5 depadding #3077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Lets see if it solves the originally reported issue.
Sorry, but not working. Here are the logs: https://gist.github.com/RufusJWB/9d287f887f16c0e4732ab59a4f82bb0c |
@RufusJWB thanks for report and log, I will investigate it along with the recent changes to minidriver. |
98ed5d8
to
de25718
Compare
I have found some additional issues
|
I can confirm, the bug is fixed now. |
@RufusJWB Thanks for testing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two minor comments.
As we are not Windows developers, is there somebody from you reporting this issue, able to put together some (ideally automated) tests of the minidriver to avoid such issues in the future? Or at least be able to run some manual tests before the release?
Sorry, but not me.
Yes, I'd be happy to support. Ideally, you would provide a WinGet package with the pre-releases. I once opened an issue #2699 about this, which we might want to re-visit. |
It looks like there is (outdated) opensc 0.23.0 as for today: created after your request in microsoft/winget-pkgs#123939 so maybe just opening another to update would get it updated (or just opening a PR to update it) -- they just point out to our installers in github releases which do not look that complicated. |
I wasn't aware, that this topic was picked up by someone at Microsoft. Great news. I'll follow up with them. |
Thank you! |
Fixes #3076
The PKCS#1 v1.5 depadding function returned correctly the length of resulting message, but the
out_len
used in minidriver was not set to the length of the depadded message.Checklist