Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PKCS#1 encoding function to correctly detect padding type #3075

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Fix PKCS#1 encoding function to correctly detect padding type #3075

merged 1 commit into from
Mar 20, 2024

Conversation

xhanulik
Copy link
Contributor

@xhanulik xhanulik commented Mar 18, 2024 •
edited

Fixes #3072

Set correct PKCS#1 v1.5 padding type when computing signature or doing decryption with pkcs15-crypt tool.

Checklist
  • Documentation is added or updated
  • New files have a LGPL 2.1 license statement
  • PKCS#11 module is tested
  • Windows minidriver is tested
  • macOS tokend is tested

@frankmorgner frankmorgner merged commit 03b7969 into OpenSC:master Mar 20, 2024
41 of 44 checks passed
@frankmorgner
Copy link
Member

thanks

@ashort96
Copy link

I noticed a newer version of OpenSC came out, but this fix was not included; is there another release planned soon that will include this fix?

@frankmorgner

@dwhjames dwhjames mentioned this pull request May 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jakuje Jakuje Jakuje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pkcs15-crypt signing fails on release 0.25.0 w/ a YubiKey-bound RSA key
4 participants
@xhanulik @frankmorgner @ashort96 @Jakuje