Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support uncompressed certificates on IDPrime 940 #2958

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

Nihlus
Copy link
Contributor

@Nihlus Nihlus commented Dec 12, 2023

This PR intends to fix handling of uncompressed certificates in Gemalto IDPrime cards. I'm currently testing this on a 940 (applet version 4), but other card variants may be affected.

Specifically, the PR fixes a bug with the data caching when reading binary data from the card, as well as ensuring that the on-card file sizes are known regardless of the compression state of the file.

Fixes #2956.

Checklist
  • Documentation is added or updated
  • PKCS#11 module is tested
  • Windows minidriver is tested
  • macOS tokend is tested

Copy link
Member

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with all bunch cards I have lying around and all looks good! Thank you for your contribution!

@Nihlus
Copy link
Contributor Author

Nihlus commented Dec 19, 2023

Excellent! Now to start messing with the IDEMIA 9 cards...

Copy link
Member

@frankmorgner frankmorgner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let us know when you think this PR is finalized

@Jakuje
Copy link
Member

Jakuje commented Dec 20, 2023

From my side, I think we are good, but I would like @xhanulik to check the modified code for the certificate compression.

@Nihlus Nihlus changed the title [WIP] Support uncompressed certificates on IDPrime 940 Support uncompressed certificates on IDPrime 940 Dec 20, 2023
@Nihlus
Copy link
Contributor Author

Nihlus commented Dec 20, 2023

I'm also happy with it, provided nothing else comes up.

Copy link
Contributor

@xhanulik xhanulik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Jakuje Jakuje merged commit c20e070 into OpenSC:master Jan 4, 2024
35 of 36 checks passed
@Jakuje
Copy link
Member

Jakuje commented Jan 4, 2024

Thank you!

@Jakuje
Copy link
Member

Jakuje commented May 23, 2024

@Nihlus can you send me the ATRs your card have? I would like to collect them in one place so we can detect issues in overlapping ATR masks such as #3106 in the future.

@Nihlus
Copy link
Contributor Author

Nihlus commented May 23, 2024

@Jakuje Unfortunately, I no longer have access to the cards I used while implementing support. I've changed workplaces and of course had to turn in my smartcard :(

I could try to get one of my previous colleagues in the loop on this issue to see if they're up for it.

@Jakuje
Copy link
Member

Jakuje commented May 23, 2024

@Jakuje Unfortunately, I no longer have access to the cards I used while implementing support. I've changed workplaces and of course had to turn in my smartcard :(

I could try to get one of my previous colleagues in the loop on this issue to see if they're up for it.

Thank you! If you have someone that would be willing to provide this information, it would be helpful.

Lets continue discussion in #3154 -- I was not sure if tagging you there would work to send out the notification.

@viljo
Copy link

viljo commented Jun 25, 2024

@Jakuje sorry guys have been keeping myself busy, expecially now when @Nihlus has left his work to me :) Here is the string reqested from @Nihlus card:
3b:7f:96:00:00:80:31:80:65:b0:85:03:00:ef:12:02:f0:82:90:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No certificates recognized on a Gemalto IDPrime 940
5 participants