Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes for Idprime 940 #2878

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Minor fixes for Idprime 940 #2878

merged 2 commits into from
Sep 30, 2023

Conversation

Jakuje
Copy link
Member

@Jakuje Jakuje commented Sep 27, 2023

Fixes: #2877

The keyrefmap was mandatory to start processing index file, which was a regression since 0.23.0, where users reported the card worked for them already.

Additionally, the signature pin was label was not propagated to the PKCS#15 objects and only printed in debug messages.

Checklist
  • PKCS#11 module is tested
  • Windows minidriver is tested
  • macOS tokend is tested

@Jakuje Jakuje added this to In progress in OpenSC 0.24.0 via automation Sep 27, 2023
Copy link
Contributor

@xhanulik xhanulik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing.

@frankmorgner frankmorgner merged commit 33dd3a2 into OpenSC:master Sep 30, 2023
35 of 36 checks passed
OpenSC 0.24.0 automation moved this from In progress to Done Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

IDPrime 940: Failed to connect to card: Invalid arguments
3 participants