Implement the Official PKCS#11 Test Cases from v3.1

[frankmorgner]

Problem Description

With PKCS#11 3.1, OASIS has created some test cases, which would be nice to pass with OpenSC.

• https://www.oasis-open.org/2022/07/25/pkcs-11-profiles-v3-1-from-pkcs-11-tc-approved-as-a-committee-specification/
• https://youtu.be/vgQiYptgzh8?t=964

[bharsaklemukesh975]

Hello, Can I work on this as my first open-source contribution?

[frankmorgner]

I'd love to see that. From what I read from the specification the task would be to

1. set up some testing environment with a virtual card just like we have in CI
2. create some new program or use pkcs11-tool to help with bootstrapping the process
3. map the XML specified test cases to some actual PKCS#11 calls

As alternative we also have some test cases in src/tests/p11test. But using the pkcs#11 test cases could provide some benefit also to other pkcs#11 modules than just OpenSC, which is why I think such a test program should be shipped seperately.

[bharsaklemukesh975]

May I know the steps to set up some testing environment with a virtual card just like we have in CI?

[frankmorgner]

It is implemented in the workflow files in .github. For testing a PIV card, for example, you would run

1. ./.github/setup-linux.sh piv
2. ./.github/test-piv.sh

[bharsaklemukesh975]

I am getting the following error while calling ./.github/test-piv.sh

card-openpgp.c:1164:7: error: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
func(blob);
^

[frankmorgner]

Thanks for pointing that out, I've created a fix here #2748

[bharsaklemukesh975]

I will start this once we have #2748 completed.

[frankmorgner]

Done

[bharsaklemukesh975]

Thanks @frankmorgner , any idea about the following compilation error, I see used after set?

pkcs11-tool.c:7364:6: error: variable 'errors' set but not used [-Werror,-Wunused-but-set-variable]
int errors = 0;
^

[frankmorgner]

I've opened an other fixup #2749

If you stumble on more issues, feel free to create a fixup yourself 😉

[bharsaklemukesh975]

Thanks understood!

[bharsaklemukesh975]

I have opened another fixup #2750 for a similar warning.
@frankmorgner can you please review?
Thanks!