Fix error when signing with Swedish BankID card #272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change could cause problems with other cards which use the same code. |
Added card type check in addition to check for SC_SEC_ENV_KEY_REF_PRESENT Added card type check in addition to check for SC_SEC_ENV_KEY_REF_PRESENT
|
Ok, put a check for card type in card-setcos.c instead. |
|
Applied in 139333f, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Swedish BankID cards (at least card type 6006 and probably 6005) have key reference 0, but SC_SEC_ENV_KEY_REF_PRESENT should not be set since this causes an error when creating a signature (using fribid on Ubuntu x64). Also see https://en.it-usenet.org/thread/11873/12745/. This commit fixes #265