Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: Workaround broken Github image #2458

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Conversation

Jakuje
Copy link
Member

@Jakuje Jakuje commented Nov 29, 2021

Fixes: #2456

Related: actions/runner-images#4589

Checklist
  • Documentation is added or updated
  • New files have a LGPL 2.1 license statement
  • PKCS#11 module is tested
  • Windows minidriver is tested
  • macOS tokend is tested

@Jakuje
Copy link
Member Author

Jakuje commented Nov 29, 2021

For the record, this looks like it is not yet complete solution as it looks like the following step is failing silently

+ wine isetup-5.5.6.exe /SILENT /VERYSILENT /SP- /SUPPRESSMSGBOXES /NORESTART

as well as the fiollowing one, because the installation above probably failed:

+ wine 'C:/Program Files/Inno Setup 5/ISCC.exe' win32/OpenSC.iss
wine: cannot find 'C:/Program Files/Inno Setup 5/ISCC.exe

and then we are failing to upload artifacts

Warning: No files were found with the provided path: win32/Output/OpenSC*.exe. No artifacts will be uploaded.

and the push-artifacts task fails because there are no artifacts to pull from cache.

This happens for both 64b and 32b versions.

https://github.com/Jakuje/OpenSC/actions/runs/1517493522

@Jakuje
Copy link
Member Author

Jakuje commented Nov 29, 2021

Not sure what /SILENT /VERYSILENT does but it looks like it makes the wine installation hang for no apparent reason.

@dengert if you have some idea what might be going on there, any tips would be appreciated. Hopefully we will get some working image in week or two from Github, but there still might some other issue.

@Jakuje
Copy link
Member Author

Jakuje commented Nov 30, 2021

no idea ... the installation just fails. No warnings from wine are useful so I give up for today.

@Jakuje
Copy link
Member Author

Jakuje commented Nov 30, 2021

lol. Now with 3b18674 where I added exactly the same package list as before, technically dropping libwine libwine:i386 wine64 (against suggestion from the Debian docs), it looks like it works fine again. Let me wait for the jobs to finish and squash that.

@Jakuje
Copy link
Member Author

Jakuje commented Nov 30, 2021

@dengert unless you will have some concerns about this, I will merge this version soon to get the green-tick again and to make the CI working in PRs again.

@dengert
Copy link
Member

dengert commented Nov 30, 2021

No concerns. I was not so much interested in mingw but in not having the green ticks!

I had said my xubuntu-20.04 system could not find the wine32 package. But I was using the synaptic "quick" search, which could not find it. The full search and apt show wine32 found it.

I think Github or Ubuntu fixed the problem. I suspect it was in the repositories or their order or caching.

@Jakuje
Copy link
Member Author

Jakuje commented Nov 30, 2021

No concerns. I was not so much interested in mingw but in not having the green ticks!

I had said my xubuntu-20.04 system could not find the wine32 package. But I was using the synaptic "quick" search, which could not find it. The full search and apt show wine32 found it.

I think you would need to add the 32 arch to find it.

I think Github or Ubuntu fixed the problem. I suspect it was in the repositories or their order or caching.

Not yet. What we have here is a workaround that we will have to eventually remove, after they will fix it, but I do not suspect it will be earlier than in a week.

@Jakuje Jakuje merged commit 33a22c8 into OpenSC:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github actions build-mingw and build-build-mingw32 are failing
2 participants