-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve warning: assignment discards 'const' qualifier from pointer target type #245
Comments
On Sunday, June 01 at 02:53AM, viktorTarasov wrote:
First of all: Some years ago I proposed a generalized form of SM, which Second, earlier this year I proposed a patch fixing all warnings by |
First: Second: Do you consider this issue as non-minor and preventing the publication of the next release ? |
Let's don't grieve about the past. I think the most pragmatic solution would be to change the type of sc_apdu_t.data back to const and cast the few occurences where non-const is needed. Windows warnings need to be fixed from peoples using OpenSC Windows. I personally don't even know where to find VS projects for OpenSC. (I would be curious about it, though.) |
frankmorgner commented Friday at 10:05 PM
There is no supported VS project, |
In my eyes, the MSIs are untrusted since I can't build and verify them |
https://www.opensc-project.org/opensc/wiki/WindowsInstaller# CI builds it like this:
|
The last 'const' warnings are from here: If there are no objections, I'd like to merge #311 |
This warning became quite frequent after the data member of sc_apdu lost it's const qualifier.
It was done to allow the background treatment of SM wrap/unwrap of the APDU data. Probably solution was not the best and there exists a better one.
The text was updated successfully, but these errors were encountered: